fix(node): classify connect_async failures as WebSocket and use Url parse error #19286
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connect() function incorrectly mapped websocket handshake/transport failures from tokio-tungstenite connect_async into EthStatsError::InvalidUrl, which conflated network errors with URL format issues. This patch reclassifies those errors to EthStatsError::WebSocket and uses the existing Url(ParseError) variant for Url::parse failures. It also avoids unnecessary URL string conversion by passing url.as_str() to connect_async. This ensures accurate error semantics consistent with the error enum design and improves debuggability.