Skip to content

fix(node): classify connect_async failures as WebSocket and use Url parse error #19286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2025
Merged

fix(node): classify connect_async failures as WebSocket and use Url parse error #19286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions crates/node/ethstats/src/ethstats.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,9 @@ where
"Attempting to connect to EthStats server at {}", self.credentials.host
);
let full_url = format!("ws://{}/api", self.credentials.host);
let url = Url::parse(&full_url)
.map_err(|e| EthStatsError::InvalidUrl(format!("Invalid URL: {full_url} - {e}")))?;
let url = Url::parse(&full_url).map_err(EthStatsError::Url)?;

match timeout(CONNECT_TIMEOUT, connect_async(url.to_string())).await {
match timeout(CONNECT_TIMEOUT, connect_async(url.as_str())).await {
Ok(Ok((ws_stream, _))) => {
debug!(
target: "ethstats",
Expand All @@ -123,7 +122,7 @@ where
self.login().await?;
Ok(())
}
Ok(Err(e)) => Err(EthStatsError::InvalidUrl(e.to_string())),
Ok(Err(e)) => Err(EthStatsError::WebSocket(e)),
Err(_) => {
debug!(target: "ethstats", "Connection to EthStats server timed out");
Err(EthStatsError::Timeout)
Expand Down
Loading