-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flags to ParcelOptions #9551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8500c1
to
ed29f63
Compare
mattcompiles
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one bud
3 tasks
MonicaOlejniczak
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR is the first part of implementing #9539. It adds a strongly typed
FeatureFlags
toParcelOptions
, which are also available inPluginOptions
.Initially, this change also implemented the ability to set feature flags via
.parcelrc
, but this was removed as it was a) deemed initially unnecessary if CLI options are available, b) a philosophical shift in what.parcelrc
is for, so now it's a lot smaller.This change has an
exampleFeature
feature flag that doesn't get used in the code, but is mostly there to differentiate from an empty feature flags object, and to allow for some integration testing.In the integration tests, it does appear that the
RequestGraph
correctly gets invalidated by feature flag changes because ofinvalidateOnOptionChange
- however I'm not sure if that's only applying to transformations or other phases as well, I will validate this and follow up if required to ensure feature flags correctly invalidate other parts as well. Admittedly this is an area where I don't have a deep understanding.A follow-up change will add support for setting feature flag values via CLI options.
💻 Examples
With trunk based development, feature flags will be used to merge changes to
v2
that are not intended / ready for most people to use, but we want to test internally. This is as opposed to what might happen today which is a long running branch, and eventually merging when either ready, or behind someunstable
options. See #9539 for more details.🚨 Test instructions
There is an integration test.
✔️ PR Todo