Array syntax

[MathiasReker]

PHP arrays should be declared using the short syntax.

[localheinz]

👍

[cmb69]

Besides that this PR has merge conflicts, I really think we should discuss the introduction of a coding standard on the webmaster mailing list.

[localheinz]

@cmb69

I have sent an email on June 17 - not sure if anyone received it or nobody has an interest in discussing it:

[cmb69]

Indeed, the mail went through; however, I missed it, and have only yet replied.

[localheinz]

For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.8.0/doc/rules/array_notation/array_syntax.rst.

[localheinz]

@MathiasReker

Once #559 has been merged, how do you feel about adjusting this pull request here by

• applying this patch

  diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php
  index b2d69e0e..e9bb8e25 100644
  --- a/.php-cs-fixer.php
  +++ b/.php-cs-fixer.php
  @@ -9,6 +9,10 @@ $finder = $config->getFinder()
       ->in(__DIR__)
       ->name(__FILE__);
  
  -$config->setRules([]);
  +$config->setRules([
  +    'array_syntax' => [
  +        'syntax' => 'short',
  +    ],
  +]);
  
  return $config;

  or this patch

  diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php
  index b2d69e0e..5d466468 100644
  --- a/.php-cs-fixer.php
  +++ b/.php-cs-fixer.php
  @@ -9,6 +9,8 @@ $finder = $config->getFinder()
       ->in(__DIR__)
       ->name(__FILE__);
  
  -$config->setRules([]);
  +$config->setRules([
  +    'array_syntax' => true,
  +]);
  
  return $config;

• committing and pushing to fail the build

• running

  make coding-standards

• committing and pushing to fix the build

[localheinz]

@cmb69 @MathiasReker

I have opened #659 as a replacement!

[cmb69]

I'm closing this, since #659 also adds the respective fixer. Nonetheless, thanks for the PR!