Enhancement: Enable array_syntax fixer
#659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
changed the title
array_syntax fixer
localheinz
force-pushed
the
feature/array-syntax
branch
from
09a599a to
56a91e4
Compare
Closed
localheinz
force-pushed
the
feature/array-syntax
branch
from
a93c965 to
f616e01
Compare
cmb69
approved these changes
Jul 15, 2022
|
We could also configure the fixer to use long syntax. |
|
Well, I prefer the short syntax (nowadays for all cases). I just don't want to go ahead and merge, to give others time to object. |
|
Please use short syntax only. The long array syntax is less readable most of the time. |
localheinz
force-pushed
the
feature/array-syntax
branch
3 times, most recently
from
a8cb04c to
0c8f37d
Compare
localheinz
force-pushed
the
feature/array-syntax
branch
from
f2e1b35 to
1cc889a
Compare
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: MathiasReker <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: MathiasReker <[email protected]>
cmb69
force-pushed
the
feature/array-syntax
branch
from
1d5e0c4 to
35c52fd
Compare
|
Thank you! |
|
Thank you, @cmb69 and @kamil-tekiela! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
array_syntaxfixermake coding-standardsReplaces #532.
Follows #559.
💁♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/array_notation/array_syntax.rst.