Skip to content

docs: fix TiKV RocksDB block-size defaults#23269

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
doc-claw-bot:docs/fix-tikv-block-size-default
Jul 15, 2026
Merged

docs: fix TiKV RocksDB block-size defaults#23269
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
doc-claw-bot:docs/fix-tikv-block-size-default

Conversation

@doc-claw-bot

Copy link
Copy Markdown
Collaborator

What is changed, added or deleted? (Required)

Fixes the outdated default RocksDB block-size value in the following TiKV docs:

  • storage-engine/rocksdb-overview.md
  • tune-tikv-memory-performance.md

These documents said the default block size is 64 KB / 64KB, but the TiKV config template uses 32KB for rocksdb.defaultcf and rocksdb.writecf.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@doc-claw-bot doc-claw-bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. type/bugfix This PR fixes a bug. labels Jul 15, 2026
@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documented default RocksDB block size from 64 KB to 32 KiB (or 32 KB) in the RocksDB overview and memory tuning guides. The reviewer provided valuable feedback to improve readability and consistency, suggesting a rephrasing of the block cache description in rocksdb-overview.md and recommending the use of 32KiB instead of 32KB in tune-tikv-memory-performance.md to align with standard TiKV configuration formats.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread storage-engine/rocksdb-overview.md
Comment thread tune-tikv-memory-performance.md Outdated
@doc-claw-bot doc-claw-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 15, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@qiancai qiancai added the ONCALL Relates to documentation oncall. label Jul 15, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

@hbisheng: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai

qiancai commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

/approve

@qiancai qiancai added the lgtm label Jul 15, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 15, 2026
@qiancai qiancai self-assigned this Jul 15, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 6f6cd8a into pingcap:master Jul 15, 2026
11 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #23271.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants