docs: fix TiKV RocksDB block-size defaults (#23269)#23271
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request updates the default RocksDB block size from 64 KB to 32 KiB in both the overview and memory performance tuning documentation. The reviewer suggested rephrasing a sentence in the overview document to improve clarity, simplicity, and readability, adhering to the repository style guide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #23269
What is changed, added or deleted? (Required)
Fixes the outdated default RocksDB
block-sizevalue in the following TiKV docs:storage-engine/rocksdb-overview.mdtune-tikv-memory-performance.mdThese documents said the default block size is
64 KB/64KB, but the TiKV config template uses32KBforrocksdb.defaultcfandrocksdb.writecf.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?