-
Notifications
You must be signed in to change notification settings - Fork 57
changeable nat64 prefix, and large-ish UX changes #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…r, ending up with the windows size as something like 400 but the body size as something like 401. fixedish by adding check to only enable scrollbar is the diff is more then 2
…anges nat64 prefix when the changes are invalid
|
FYI if you do end up adding automatic prefix detection there is a domain specifically for this purpose set aside by IANA. It's technically designed for auto configuration of 464XLAT but could be used here. ipv4only.arpa |
|
@asdfjkluiop i don't think you can do dns queries in extensions, which is why i didn't suggest it. also as far as i know pref64 is preferred these days but less commonly supported, and i don't think you could get that via extension either |
|
The problem with perf64 is not all networks advertise it and I'd be surprised if the extension could get that info anyway. I'm not sure if it's possible to do dns queries in an extension, I just saw you mention needing something like ipv4.google.com and I wanted to make sure that if the feature was being pursued that other more standard options were known about. |
|
IPvFoo's dynamic NAT64 support needs to meet my personal standards of perfectionism and simplicity, but I've been too lazy to sit down and figure out what that actually means, which is why I haven't done anything yet. |
|
LOL, as a fellow developer I understand the sentiment. It would be really nice to have though, I'm currently running a patched version with my prefix that ff doesn't like because it isn't signed |
|
I've come up with a solution that avoids manual prefix management. Would you like to try v2.19 in the master branch, and/or comment on #60 ? |
b355910 to
f7d5e36
Compare
00b54be to
0fd3d6a
Compare
Backend
additions and changes:
there is also no automatic nat64 prefix detection which is a feature some people seemed to want.
doing that in the extension itself seems like it would require pinging something like ipv4.google.com and,
you'd probably want caching,
there'd be a tradeoff between how often you check the nat64 prefix and how many network requests you make,
for something like a laptop or phone you might want to update every few hours but longer would be better for stationary devices
you could also try to use a separate program like Yomitan can (for a different purpose) to get the nat64 prefix from the OS.
UX
additions and changes:
sans-serifinstead of defaulting toNoto SansandArial, im not sure the reason that was done, i think using the user's selected font works better hereknown issues:
onmousedown is used is responsiveness for anything the user wouldn't want to cancel, like checking a checkbox or selecting a radio button.
i've also tested on mobile and it works fine there.
also if you have any other ideas for onmousedown for checkboxes and radio buttons let me know, the current method is kinda janky, though i haven't had any issues with it so far.
misc
this changes the makefile to make an unpacked chrome build, i didn't see any instructions for a development workflow so i just loaded the unpacked extension and then reloaded it when i changed something, i can remove it from the makefile if you want.