feat: bootc 1.5.0 release #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim deBoer <[email protected]>
deboer-tim
requested review from
dgolovin,
cdrage and
gastoner
and removed request for
a team
|
I think it's safer to push to gh-pages branch as I got requested for changes, I'll handle the backport to the main branch 👍 |
|
I just cherry-picked it over to gh-pages in #79, easy enough to do it in both. IMHO it's fine to switch publishing to this branch (and stop gh-pages) as long as /api still works though. Like Storybook it's fine if new web content is publicly accessible, we just won't tell anyone / link to it until it's ready. |
|
yes the only issue is that merging to this branch won't publish the website to gh-pages ( it'll just be a merged commit, that's all) soon, having proper job yes it'll do the job |
benoitf
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish the bootc 1.5.0 release.
Previous PR says gh-pages has been moved the main branch, but content still exists on gh-pages branch and it doesn't look like main has been published yet. Assuming this is coming soon I'm PR'ing here, but if it's not this week I can PR on gh-pages too.