refactor: Separate HivePrestoToVeloxConnector to standalone file

[PingLiuPing]

Description

This is a follow up PR of #26237 (comment)

This is a straightforward refactor.

Motivation and Context

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.
• If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's Guide

The PR refactors the Hive connector by moving all Hive-specific conversion logic and class implementation out of the generic PrestoToVeloxConnector into a dedicated HivePrestoToVeloxConnector module and consolidates shared helper functions into a utils file, updating build and includes accordingly.

Class diagram for refactored HivePrestoToVeloxConnector

classDiagram
    class PrestoToVeloxConnector {
        <<abstract>>
        +connectorName_: string
        +~PrestoToVeloxConnector()
        +toVeloxSplit(...)
        +toVeloxColumnHandle(...)
        +toVeloxTableHandle(...)
        +toVeloxInsertTableHandle(...)
        +createVeloxPartitionFunctionSpec(...)
        +createConnectorProtocol()
    }
    class HivePrestoToVeloxConnector {
        +HivePrestoToVeloxConnector(connectorName: string)
        +toVeloxSplit(...)
        +toVeloxColumnHandle(...)
        +toVeloxTableHandle(...)
        +toVeloxInsertTableHandle(...)
        +createVeloxPartitionFunctionSpec(...)
        +createConnectorProtocol()
        -toHiveColumns(...)
    }
    PrestoToVeloxConnector <|-- HivePrestoToVeloxConnector

    class TpchPrestoToVeloxConnector {
        +TpchPrestoToVeloxConnector(connectorName: string)
        +toVeloxSplit(...)
        +toVeloxColumnHandle(...)
        +toVeloxTableHandle(...)
        +toVeloxInsertTableHandle(...)
        +createVeloxPartitionFunctionSpec(...)
        +createConnectorProtocol()
    }
    PrestoToVeloxConnector <|-- TpchPrestoToVeloxConnector

Loading

Class diagram for helper function relocation

classDiagram
    class PrestoToVeloxConnectorUtils {
        +toRequiredSubfields(...)
        +toFileCompressionKind(...)
        +toVeloxFileFormat(...)
        +toJsonString(...)
        +toFilter(...)
    }
    class HivePrestoToVeloxConnector {
        +toVeloxSplit(...)
        +toVeloxColumnHandle(...)
        +toVeloxTableHandle(...)
        +toVeloxInsertTableHandle(...)
        +createVeloxPartitionFunctionSpec(...)
        +createConnectorProtocol()
        -toHiveColumns(...)
    }
    HivePrestoToVeloxConnector ..> PrestoToVeloxConnectorUtils : uses

Loading

File-Level Changes

Change	Details	Files
Extract Hive connector into standalone module	Introduced HivePrestoToVeloxConnector.h/.cpp with full HivePrestoToVeloxConnector implementation Removed Hive-specific methods and logic from PrestoToVeloxConnector.cpp/.h Updated PrestoToVeloxConnector to focus on generic connector API	PrestoToVeloxConnector.cpp PrestoToVeloxConnector.h HivePrestoToVeloxConnector.cpp HivePrestoToVeloxConnector.h
Relocate shared helper functions to utils	Created PrestoToVeloxConnectorUtils.h/.cpp housing toRequiredSubfields, toFileCompressionKind, toVeloxFileFormat, toJsonString Removed duplicate utility implementations from other source files Updated utils header with proper includes for protocol and Velox DWIO	PrestoToVeloxConnectorUtils.cpp PrestoToVeloxConnectorUtils.h
Update build and include references	Added HivePrestoToVeloxConnector.cpp to CMakeLists.txt Registered new Hive connector in Registration.cpp Replaced PrestoToVeloxConnector.h includes with HivePrestoToVeloxConnector.h in tests and Iceberg connector	CMakeLists.txt Registration.cpp IcebergPrestoToVeloxConnector.cpp TaskInfoTest.cpp PlanConverterTest.cpp PrestoToVeloxConnectorTest.cpp PrestoToVeloxSplitTest.cpp TaskManagerTest.cpp TaskUpdateRequestTest.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[PingLiuPing]

@aditi-pandit This is a followup PR based on your review comments. Can you help to have a look? Thanks.

[aditi-pandit]

Thanks @PingLiuPing. Code looks good minus nit.

[aditi-pandit]

Thanks @PingLiuPing

[amitkdutta]

@PingLiuPing We have a dependency on this function interanlly at Meta but moving it to annonymous namespace broke the internal build :(. Probably better to keep it in header, otherwise we need to copy paste the function. Since the function is in a header, its an open dependency. Probably we keep this in header so that downstream does not need to copy it.