Fix #4027 #5208
Fix #4027 #5208
Conversation
|
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
size-limit report 📦
|
| @@ -31,5 +32,5 @@ export function useResizeObserver<T extends HTMLElement>(callback: ResizeObserve | |||
| return () => { | |||
| observer.disconnect() | |||
| } | |||
| }, [target]) | |||
| }, [targetEl]) | |||
There was a problem hiding this comment.
Note for reviewer: Adding a ref as dependency isn't a recommended pattern as changes to the value of the ref does not cause the effect to re-run. Replaced the ref with targetEl instead
| @@ -107,7 +107,7 @@ export const AnchoredOverlay: React.FC<React.PropsWithChildren<AnchoredOverlayPr | |||
| overlayProps, | |||
| focusTrapSettings, | |||
| focusZoneSettings, | |||
| side = 'outside-bottom', | |||
| side = overlayProps?.['anchorSide'] || 'outside-bottom', | |||
There was a problem hiding this comment.
Let's not do this just yet. Pull this out to another PR of it's own
| @@ -45,7 +45,8 @@ export function useAnchoredPosition( | |||
|
|
|||
| useLayoutEffect(updatePosition, [updatePosition]) | |||
|
|
|||
| useResizeObserver(updatePosition) | |||
| useResizeObserver(updatePosition) // watches for changes in window size | |||
| useResizeObserver(updatePosition, floatingElementRef as React.RefObject<HTMLElement>) // watches for changes in floating element size | |||
There was a problem hiding this comment.
Note for self: This needs to be opt-in. A bit risky to always do this because it would keep jumping around.
Goal: Once SelectPanel opens upwards, do not resize it anymore.
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist