Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4027 #5208

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Fix #4027 #5208

wants to merge 6 commits into from

Commits on Nov 1, 2024

  1. try to repro #4027

    @siddharthkp
    siddharthkp committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    0c4b83a View commit details
    Browse the repository at this point in the history

  2. add panel inside dialog

    @siddharthkp
    siddharthkp committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e919c18 View commit details
    Browse the repository at this point in the history

  3. add repro in anchored overlay

    @siddharthkp
    siddharthkp committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    0f4736a View commit details
    Browse the repository at this point in the history

  4. add resize observer for floating element

    @siddharthkp
    siddharthkp committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c31f358 View commit details
    Browse the repository at this point in the history

  5. use targetEl instead of ref as effect dependency 

    refs do not trigger effect to rerun
    @siddharthkp
    siddharthkp committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    bd49a62 View commit details
    Browse the repository at this point in the history

  6. respect overlay props for anchor side

    @siddharthkp
    siddharthkp committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    b316bb1 View commit details
    Browse the repository at this point in the history