Handle datetimes with time zone information in crypto.X509Store.set_time() #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime() pyca#907 fixed the issue with set_time() not working on Windows. It also changed set_time()'s behavior in an incompatible way: instead of treating vfy_time always being in local time (regardless if it had a time zone attached or not), it now treats vfy_time as a time in UTC. This patch improves on that by taking the time zone into account, and also documents the incompatible change. Note that it is not always possible to convert a timestamp in an arbitrary time zone into UTC unambiguously, due to repeated or skipped local times around DST changes. The best is to use a timezone-aware vfy_time using the UTC time zone.
orosam
force-pushed
the
x509-store-set-time
branch
from
e380917
to
6306250
Compare
|
Two checks appear to be failing due to cryptography no longer allowing OpenSSL 1.0.2. |
|
flips table Ok, I guess we'll need to figure that out before we can review your PR. THank you for sending it! |
|
Is it possible to write a test case for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#907 fixed the issue with
set_time()not working on Windows.It also changed
set_time()'s behavior in an incompatible way: instead oftreating
vfy_timealways being in local time (regardless if it had a timezone attached or not), it now treats
vfy_timeas a time in UTC.This patch improves on that by taking the time zone into account, and also
documents the incompatible change.
Note that it is not always possible to convert a timestamp in an arbitrary
time zone into UTC unambiguously, due to repeated or skipped local times
around DST changes. The best is to use a timezone-aware
vfy_timeusing the UTC time zone.