Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle datetimes with time zone information in crypto.X509Store.set_time() #952

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle datetimes with time zone information in crypto.X509Store.set_time() #952

wants to merge 1 commit into from

Commits on Oct 26, 2020

  1. Handle datetimes with time zone information in crypto.X509Store.set_t… 

    …ime()

pyca#907 fixed the issue with set_time() not working on Windows.
It also changed set_time()'s behavior in an incompatible way: instead of
treating vfy_time always being in local time (regardless if it had a time
zone attached or not), it now treats vfy_time as a time in UTC.

This patch improves on that by taking the time zone into account, and also
documents the incompatible change.

Note that it is not always possible to convert a timestamp in an arbitrary
time zone into UTC unambiguously, due to repeated or skipped local times
around DST changes. The best is to use a timezone-aware vfy_time
using the UTC time zone.
    Sandor Oroszi committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    6306250 View commit details
    Browse the repository at this point in the history