Prevent synthetic intersections from leaking to module public interfaces #20459
+20
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20457.
In addition, 642cf64 fixes a bug which can be triggered in stubtest. Reproducer:
Admittedly, nobody should be writing
isinstance()in a stub, but it doesn't seem to be illegal to do so, and in any case auto-generated stubs may forget to strip such constructs and surface weird error messages like the one above.I tried adding a test to
teststubtest.py, but it fails because there doesn't seem to be a way to add fixtures to test cases there, which is needed to invokeisinstance(). The test is