Skip to content

Prevent synthetic intersections from leaking to module public interfaces #20459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 2 commits into from
Dec 23, 2025
+20 −1
Merged

Prevent synthetic intersections from leaking to module public interfaces #20459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c309ff
fix: prevent leaking generated intersections to star imports
bzoracler Dec 22, 2025
642cf64
fix: prevent stubtest from detecting generated intersections
bzoracler Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5968,7 +5968,7 @@ def _make_fake_typeinfo_and_full_name(
errors.append((pretty_names_list, "would have incompatible method signatures"))
return None

curr_module.names[full_name] = SymbolTableNode(GDEF, info)
curr_module.names[full_name] = SymbolTableNode(GDEF, info, False, module_hidden=True)
return Instance(info, [], extra_attrs=instances[0].extra_attrs or instances[1].extra_attrs)

def intersect_instance_callable(self, typ: Instance, callable_type: CallableType) -> Instance:
Expand Down
19 changes: 19 additions & 0 deletions test-data/unit/check-modules.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,25 @@ x = 1
[file m2.py]
x = 1

[case testStarImportDoesNotImportGeneratedIntersections]
from m1 import *
from m2 import *
[file m1.py]
from m3 import A, B

a: A
if isinstance(a, B): ...
[file m2.py]
from m3 import A, B

a: A
if isinstance(a, B): ...
[file m3.py]
class A: ...
class B: ...
class AB(A, B): ...
[builtins fixtures/isinstance.pyi]

[case testAssignToFuncDefViaImport]

# Errors differ with the new analyzer. (Old analyzer gave error on the
Expand Down