Skip to content

Update the code to be compatible with the new cuco stream-ordered allocator #20258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 22, 2025
Merged

Update the code to be compatible with the new cuco stream-ordered allocator #20258

merged 17 commits into from
Oct 22, 2025

Conversation

@PointKernel
Copy link
Member

@PointKernel PointKernel commented Oct 14, 2025 •
edited
Loading

Description

This PR updates cuco-related components in cudf to ensure compatibility with the new cuco stream-ordered allocator.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added the DO NOT MERGE Hold off on merging; see PR for details label Oct 14, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 14, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@PointKernel PointKernel changed the title Test cuco stream allocator1 Test cuco stream allocator Oct 14, 2025
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Oct 14, 2025
@PointKernel
Copy link
Member Author

PointKernel commented Oct 14, 2025

/ok to test bc5ac51

@PointKernel PointKernel mentioned this pull request Oct 15, 2025
Merged
7 tasks
@PointKernel
Copy link
Member Author

PointKernel commented Oct 15, 2025

/ok to test 02f3696

@PointKernel PointKernel mentioned this pull request Oct 16, 2025
Merged
@PointKernel PointKernel added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Oct 16, 2025
@PointKernel PointKernel changed the title Test cuco stream allocator Update the code to be compatible with the new cuco stream-ordered allocator Oct 16, 2025
@PointKernel PointKernel marked this pull request as ready for review October 16, 2025 01:45
@PointKernel PointKernel requested review from a team as code owners October 16, 2025 01:45
@PointKernel
Copy link
Member Author

PointKernel commented Oct 16, 2025

This PR is ready for review. Please note that the upstream rapids-cmake PR depends on this one and cannot be merged until it’s approved. The temporary CMake changes here will be reverted once rapidsai/rapids-cmake#929 is merged.

@PointKernel PointKernel added the 3 - Ready for Review Ready for review by team label Oct 16, 2025
ttnghia
ttnghia approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any performance impact due to such upgrade?

This was referenced Oct 16, 2025
Merged
Merged
@PointKernel
Copy link
Member Author

PointKernel commented Oct 16, 2025

Is there any performance impact due to such upgrade?

Probably not for libcudf, since the upstream change only updated the cuco allocator from cudaMalloc/cudaFree to cudaMallocAsync/cudaFreeAsync. As libcudf doesn’t use the cuco allocator, this change shouldn’t have any impact on it.

@PointKernel PointKernel added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 16, 2025
@GregoryKimball GregoryKimball moved this to Burndown in libcudf Oct 17, 2025
mhaseeb123
mhaseeb123 requested changes Oct 21, 2025
View reviewed changes
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding a request changes to avoid merging this PR without accommodating for new code in #20201 to use the same rmm::polymorphic_allocator. See #20201 (review)

Update: #20201 has been merged and we can now make the required changes here.

@PointKernel PointKernel removed DO NOT MERGE Hold off on merging; see PR for details CMake CMake build issue labels Oct 22, 2025
@PointKernel
Copy link
Member Author

PointKernel commented Oct 22, 2025

/merge

@rapids-bot rapids-bot bot merged commit 764c7e2 into rapidsai:main Oct 22, 2025
136 checks passed
@PointKernel PointKernel deleted the test-cuco-stream-alloc branch October 22, 2025 04:28
@pxLi pxLi mentioned this pull request Oct 22, 2025
Closed
@GregoryKimball GregoryKimball moved this from Burndown to Landed in libcudf Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttnghia ttnghia ttnghia approved these changes

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@PointKernel PointKernel

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

libcudf
Status: Landed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PointKernel @ttnghia @mhaseeb123