Skip to content

Deprecate Series.data #20281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 22, 2025
Merged

Deprecate Series.data #20281

merged 5 commits into from
Oct 22, 2025

Conversation

@mroeschke
Copy link
Contributor

Description

This could return a private Buffer object which I don't think we want to expose.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke self-assigned this Oct 16, 2025
@mroeschke mroeschke requested a review from a team as a code owner October 16, 2025 00:30
@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function labels Oct 16, 2025
@mroeschke mroeschke added the non-breaking Non-breaking change label Oct 16, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Oct 16, 2025
@vyasr vyasr changed the base branch from main to branch-25.12 October 20, 2025 22:51
@vyasr vyasr changed the base branch from branch-25.12 to main October 20, 2025 22:52
Matt711
Matt711 approved these changes Oct 22, 2025
View reviewed changes
python/cudf/cudf/tests/series/test_attributes.py

def test_series_data_property_deprecated():
s = cudf.Series([1, 2, 3])
with pytest.warns(FutureWarning):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

Suggested change
with pytest.warns(FutureWarning):
with pytest.warns(FutureWarning, match=...):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. I'll fold this into #20304

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 93fe5f5 into rapidsai:main Oct 22, 2025
148 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Oct 22, 2025
@mroeschke mroeschke deleted the depr/cudf/series_attrs branch October 22, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Matt711 Matt711 Matt711 approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

cuDF Python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mroeschke @Matt711