Skip to content

Deprecate Series.data #20281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 22, 2025
Merged

Deprecate Series.data #20281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee14822
Deprecate Series.data
mroeschke Oct 16, 2025
07faf5b
Merge remote-tracking branch 'upstream/branch-25.12' into depr/cudf/s…
mroeschke Oct 16, 2025
a109704
Merge remote-tracking branch 'upstream/branch-25.12' into depr/cudf/s…
mroeschke Oct 16, 2025
b86f429
Undo API doc change
mroeschke Oct 16, 2025
6efd0e0
Merge remote-tracking branch 'upstream/branch-25.12' into depr/cudf/s…
mroeschke Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/cudf/cudf/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1995,6 +1995,11 @@ def data(self):
array([1, 0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0,
0, 0, 4, 0, 0, 0, 0, 0, 0, 0], dtype=uint8)
"""
warnings.warn(
"Series.data is deprecated and will be removed in a future version. "
"Use Series.to_pylibcudf()[0].data() instead.",
FutureWarning,
)
return self._column.data

@_performance_tracking
Expand Down
6 changes: 6 additions & 0 deletions python/cudf/cudf/tests/series/test_attributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,3 +429,9 @@ def test_series_values_property(data):
gds_vals = gds.values
assert isinstance(gds_vals, cp.ndarray)
np.testing.assert_array_equal(gds_vals.get(), pds.values)


def test_series_data_property_deprecated():
s = cudf.Series([1, 2, 3])
with pytest.warns(FutureWarning):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

Suggested change
with pytest.warns(FutureWarning):
with pytest.warns(FutureWarning, match=...):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. I'll fold this into #20304

s.data
Loading