Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added dependencies required for extension installation tests #63

Merged
merged 1 commit into from
Feb 17, 2025
Merged

chore: added dependencies required for extension installation tests #63

merged 1 commit into from
Feb 17, 2025

Conversation

rostalan
Copy link
Contributor

No description provided.

@rostalan rostalan requested a review from a team as a code owner January 27, 2025 15:58
@rostalan rostalan mentioned this pull request Jan 27, 2025
Open
benoitf
benoitf approved these changes Jan 27, 2025
View reviewed changes
odockal
odockal requested changes Feb 4, 2025
View reviewed changes
@odockal
Copy link

odockal commented Feb 10, 2025

@benoitf There was missing yarn.lock file. Can you please re-review?

@rostalan
Copy link
Contributor Author

Could you please merge this @jeffmaury, we still do not have the rights to do so.

benoitf
benoitf reviewed Feb 12, 2025
View reviewed changes
Copy link

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the yarn.lock is a full rewrite of the existing file.

I would expect just the delta with new dependencies

do you know what happened ?

also vitest is at v3.0.5 so why adding that old dependency ?

@rostalan
Copy link
Contributor Author

I am not sure, the file is autogenerated, and a lot of the package versions are updated.

jeffmaury
jeffmaury requested changes Feb 14, 2025
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the same change in yarn.lock if I run yarn install locally.

Seems it may have been generated by a different version of yarn

@rostalan
Copy link
Contributor Author

rostalan commented Feb 17, 2025 •
edited
Loading

@jeffmaury yeah, it was me having version 3.6.1. of yaml, rolled it back and it gives the expected diff. Also removed the vitest dependency, because there are no unit tests present atm and it is not related to the e2e tests. The test and test:watch commands are useless atm. Created issue, vitest dep. can be added in with them.

@rostalan rostalan requested a review from jeffmaury February 17, 2025 12:10
@rostalan rostalan enabled auto-merge February 17, 2025 15:17
jeffmaury
jeffmaury approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rostalan rostalan merged commit 77b478f into redhat-developer:main Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@jeffmaury jeffmaury jeffmaury approved these changes

@odockal odockal odockal approved these changes

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from redhat-developer/podman-desktop-reviewers

@gastoner gastoner Awaiting requested review from gastoner gastoner is a code owner automatically assigned from redhat-developer/podman-desktop-reviewers

@SoniaSandler SoniaSandler Awaiting requested review from SoniaSandler SoniaSandler is a code owner automatically assigned from redhat-developer/podman-desktop-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rostalan @odockal @benoitf @jeffmaury