azure: add blob index tags support for blob storage output#4204
Open
fredmeltwater wants to merge 1 commit intoredpanda-data:mainfrom
Open
azure: add blob index tags support for blob storage output#4204fredmeltwater wants to merge 1 commit intoredpanda-data:mainfrom
fredmeltwater wants to merge 1 commit intoredpanda-data:mainfrom
Conversation
Closes redpanda-data#2904 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
meltwater-coreplatform
left a comment
meltwater-coreplatform
left a comment
There was a problem hiding this comment.
Commits
LGTM
Review
Clean implementation adding blob index tags support to the azure_blob_storage output. Tags are parsed at config time as an InterpolatedStringMap with a 10-tag limit (matching Azure's constraint), deterministically sorted, and resolved per-message. Block blobs pass tags via UploadStreamOptions; append blobs set tags at creation via CreateOptions and update them on subsequent appends via SetTags. Integration test validates tag roundtrip through Azurite.
LGTM
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tagsfield to theazure_blob_storageoutput, allowing users to set blob index tags as key/valuepairs with interpolation support
SetTagsfor append blobsreviewskill used on this PRCloses #2904
Test plan
go build ./internal/impl/azure/...passesgo test ./internal/impl/azure/... -shortpassesblob_storage_tagsvalidates tags are set correctly on block blobs via Azurite🤖 Generated with Claude Code