Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom-elements that participate in forms #13251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nowells
Copy link

@nowells nowells commented Mar 18, 2025

Right now react-router does not support component libraries that leverage custom-elements that implement the form participation api. This expands the guards checks to allow these form submit elements to function.

Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: cad407a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 18, 2025

Hi @nowells,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

Right now react-router does not support component libraries that leverage custom-elements that implement the form participation api. This expands the guards checks to allow these form submit elements to function.
@nowells nowells force-pushed the custom-element-forms branch from 0ea1c86 to cad407a Compare March 18, 2025 12:51
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 18, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@cliffordfajardo
Copy link

cliffordfajardo commented Apr 1, 2025

Right now react-router does not support component libraries that leverage custom-elements that implement the form participation api.

@nowells - curious as I'm learning, what component libraries have you used where you ran into this issue?

Future readers, found this doc on Form Participation API by google eng folks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants