Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom-elements that participate in forms #13251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support custom-elements that participate in forms #13251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@
- Nismit
- nnhjs
- noisypigeon
- nowells
- Nurai1
- Obi-Dann
- OlegDev1
Expand Down
13 changes: 13 additions & 0 deletions packages/react-router/lib/dom/dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ export function isInputElement(object: any): object is HTMLInputElement {
return isHtmlElement(object) && object.tagName.toLowerCase() === "input";
}

// for a custom element to be a form submitter it must also be a form associated custom element
// https://webkit.org/blog/13711/elementinternals-and-form-associated-custom-elements/
// https://web.dev/articles/more-capable-form-controls
function isFormAssociatedCustomElement(object : any) : object is HTMLElement {
return isHtmlCustomElement(object)
&& (object.constructor as any).formAssociated === true;
}

function isHtmlCustomElement(object : any): object is HTMLElement {
return isHtmlElement(object) && object.localName.includes('-') && Boolean(customElements.get(object.localName));
}

type LimitedMouseEvent = Pick<
MouseEvent,
"button" | "metaKey" | "altKey" | "ctrlKey" | "shiftKey"
Expand Down Expand Up @@ -278,6 +290,7 @@ export function getFormSubmissionInfo(
formData = new FormData(target);
} else if (
isButtonElement(target) ||
isFormAssociatedCustomElement(target) ||
(isInputElement(target) &&
(target.type === "submit" || target.type === "image"))
) {
Expand Down