Skip to content

Conversation

@jasonLaster
Copy link
Contributor

We've gone back and forth a couple of times here because of a miscommunication.

I think this should simplify things considerably:

  1. BaseHub is the source of truth for whether a feature is an image or video
  2. BaseHub has the video id. Eventually it'll also have the video and the image as well. That's what we're doing on docs and it's simpler.
  3. The code has the minimal amount of code needed to support images that are in the repo.

@vercel
Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 0:16am
replay ❌ Failed (Inspect) Apr 11, 2024 0:16am

Copy link
Contributor

@callingmedic911 callingmedic911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants