Skip to content

Make feature types consistent #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make feature types consistent #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions src/components/sections/DevTools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,9 @@ import network from '~/images/screenshots/view-network-requests.png'
import { LandingPageFragment } from '~/lib/basehub-queries'

const images = {
testSteps: {
type: 'image',
src: testSteps
},
console: {
type: 'mux-video',
src: '9ERwx5ymPqmmqMeRIhVqCvnhyy009017y00mtdvISQF6fI'
},
react: {
type: 'image',
src: react
},
network: {
type: 'image',
src: network
}
testSteps,
react,
network
}

export function DevTools({ devTools }: LandingPageFragment) {
Expand Down Expand Up @@ -124,15 +111,15 @@ export function DevTools({ devTools }: LandingPageFragment) {
{feature.type === 'image' ? (
<Image
className="w-full"
src={featureImage.src}
src={featureImage}
alt=""
priority
sizes="(min-width: 1024px) 67.8125rem, (min-width: 640px) 100vw, 45rem"
/>
) : (
<MuxPlayer
streamType="on-demand"
playbackId={featureImage.src as string}
playbackId={feature.video as string}
primaryColor="#FFFFFF"
secondaryColor="#000000"
muted={true}
Expand Down Expand Up @@ -181,19 +168,18 @@ export function DevTools({ devTools }: LandingPageFragment) {
</div>
</h3>
<p className={clsx('mb-8 mt-2 text-sm')}>{feature.subTitle}</p>
{featureImage.type === 'image' && (
{feature.type === 'image' ? (
<Image
className="w-full"
src={featureImage.src}
src={featureImage}
alt=""
priority
sizes="(min-width: 1024px) 67.8125rem, (min-width: 500px) 100vw, 30rem"
/>
)}
{featureImage.type === 'mux-video' && (
) : (
<MuxPlayer
streamType="on-demand"
playbackId={featureImage.src as string}
playbackId={feature.video as string}
primaryColor="#FFFFFF"
secondaryColor="#ff00ff"
muted={true}
Expand Down