Skip to content

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 10, 2025

This PR consists of changes to cleanup the saturation boolean of the PID toolbox


This is an automatic backport of pull request #390 done by Mergify.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.66667% with 35 lines in your changes missing coverage. Please review.

Project coverage is 74.81%. Comparing base (f0cf6f3) to head (250cb3e).

Files with missing lines Patch % Lines
control_toolbox/src/pid_ros.cpp 67.14% 22 Missing and 1 partial ⚠️
control_toolbox/src/pid.cpp 42.10% 9 Missing and 2 partials ⚠️
control_toolbox/include/control_toolbox/pid.hpp 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy     #393      +/-   ##
==========================================
- Coverage   74.95%   74.81%   -0.14%     
==========================================
  Files          29       29              
  Lines        1749     1783      +34     
  Branches      101      105       +4     
==========================================
+ Hits         1311     1334      +23     
- Misses        380      388       +8     
- Partials       58       61       +3     
Flag Coverage Δ
unittests 74.81% <76.66%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ontrol_toolbox/include/control_toolbox/pid_ros.hpp 100.00% <ø> (ø)
control_toolbox/test/pid_ros_parameters_tests.cpp 100.00% <100.00%> (ø)
control_toolbox/test/pid_ros_publisher_tests.cpp 95.00% <ø> (ø)
control_toolbox/test/pid_tests.cpp 100.00% <100.00%> (ø)
control_toolbox/include/control_toolbox/pid.hpp 78.26% <85.71%> (-4.10%) ⬇️
control_toolbox/src/pid.cpp 63.52% <42.10%> (-2.55%) ⬇️
control_toolbox/src/pid_ros.cpp 60.00% <67.14%> (+0.83%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 85d95c3 into jazzy Jun 11, 2025
10 of 12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-390 branch June 11, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants