Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_the_controller_update_rate is flaky #1957

Open
christophfroehlich opened this issue Dec 18, 2024 · 3 comments
Open

check_the_controller_update_rate is flaky #1957

christophfroehlich opened this issue Dec 18, 2024 · 3 comments
Assignees
Labels
CI persistent Issue won't get marked as stale stale

Comments

@christophfroehlich
Copy link
Contributor

I saw that several times now, mostly on humble

https://github.com/ros-controls/ros2_control_ci/actions/runs/12385126242/job/34570846255

     1 FAILED TEST
    -- run_test.py: return code 1
    -- run_test.py: inject classname prefix into gtest result file '/home/runner/work/ros2_control_ci/ros2_control_ci/.work/target_ws/build/controller_manager/test_results/controller_manager/test_controller_manager.gtest.xml'
    -- run_test.py: verify result file '/home/runner/work/ros2_control_ci/ros2_control_ci/.work/target_ws/build/controller_manager/test_results/controller_manager/test_controller_manager.gtest.xml'
  >>>
build/controller_manager/test_results/controller_manager/test_controller_manager.gtest.xml: 30 tests, 0 errors, 1 failure, 0 skipped
- controller_manager.per_controller_update_rate_check/TestControllerUpdateRates check_the_controller_update_rate/10
  <<< failure message
    /home/runner/work/ros2_control_ci/ros2_control_ci/.work/target_ws/src/ros-controls/ros2_control/controller_manager/test/test_controller_manager.cpp:736
    Value of: test_controller->update_period_.seconds()
    Expected: (is > 0.011) and (is < 0.0216667)
      Actual: 0.022103 (of type double)
    update_counter: 117 desired controller period: 0.011111111111111112 actual controller period: 0.022103009999999999
    /home/runner/work/ros2_control_ci/ros2_control_ci/.work/target_ws/src/ros-controls/ros2_control/controller_manager/test/test_controller_manager.cpp:736
    Value of: test_controller->update_period_.seconds()
    Expected: (is > 0.011) and (is < 0.0216667)
      Actual: 0.022103 (of type double)
    update_counter: 118 desired controller period: 0.011111111111111112 actual controller period: 0.022103009999999999
  >>>
@christophfroehlich
Copy link
Contributor Author

Copy link
Contributor

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale label Mar 31, 2025
@christophfroehlich
Copy link
Contributor Author

@christophfroehlich christophfroehlich added the persistent Issue won't get marked as stale label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI persistent Issue won't get marked as stale stale
Projects
None yet
Development

No branches or pull requests

2 participants