-
Notifications
You must be signed in to change notification settings - Fork 344
Statically allocate string concatinations using FMT #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups. |
I am not sure if I understand this issue correctly, does it mean to add something like const auto diag_summary = fmt::format(
"Controller Manager has bad periodicity: {:.2f} Hz. Expected consistent {:.2f} Hz",
cm_stats.average, get_update_rate()); to replace the original one? |
I think so, yes @saikishor? |
@mini-1235 Yes, we need to do it similar way, the only thing is it is missing |
@saikishor thanks for the guidance! I have opened a PR for it |
Originally posted by @bmagyar in #1871 (comment)
The text was updated successfully, but these errors were encountered: