Skip to content

[JTC] Add more options for tolerance configuration #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
christophfroehlich opened this issue Jun 24, 2024 · 2 comments · May be fixed by #1677
Open

[JTC] Add more options for tolerance configuration #1180

christophfroehlich opened this issue Jun 24, 2024 · 2 comments · May be fixed by #1677
Assignees
@Vedant87
Labels
good second issue stale

Comments

@christophfroehlich
Copy link
Contributor

From the node parameter we cannot set velocity or acceleration tolerances (except for a single stopped_velocity_tolerance for the goal tolerances of all joints). Should we add them as parameters as well, to have the same structure like the action message?

This would be nice to have in the follow-up PR.

Originally posted by @destogl in #716 (review)
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this issue Jul 19, 2024
@saikishor
Fix controller sorting issue while loading large number of controllers (
d68cc22 
ros-controls#1180)
@github-actions GitHub Actions
Copy link
Contributor

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale label Mar 28, 2025
@christophfroehlich christophfroehlich pinned this issue Mar 28, 2025
@Vedant87
Copy link
Contributor

Hello @christophfroehlich, I would like to contribute.

@Vedant87 Vedant87 linked a pull request May 11, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vedant87 Vedant87

Labels
good second issue stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JTC add more options for tolerance configuration Vedant87/ros2_controllers
2 participants
@christophfroehlich @Vedant87