Update imemo_mask to match ruby's #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The imemo mask has been `0xf` since Ruby 2.5 / ccfe37884ab566336380d0f21e15321d6382da8f This hasn't caused problems yet because the only possible conflict is `imemo_type = 15`, but it is not yet used.
❌ Tests Failed✖️no tests failed ✔️541 tests passed(139 flakes) |
Member
Author
|
The failure are unrelated AFAICT, other PRs have them too. |
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The imemo mask has been
0xfsince Ruby 2.5 / ccfe37884ab566336380d0f21e15321d6382da8fThis hasn't caused problems yet because the only possible conflict is
imemo_type = 15, but it is not yet used.But this begs the question of how we can keep these two in sync, because
imemo_type = 15is the last free imemo type, so the mask may be enlarged again soon.