Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replicate fuzz #250

Closed
wants to merge 1 commit into from
Closed

Conversation

sanket1729
Copy link
Member

303439353462626261626262626262626261626262626262626230346262
626261626262626262626262626262626262626262626262626262626262
626262623735626262626262626262626262626262626262626262626262
626262626262626262626262623834626262626262426262626262623637
35343030326262356262

Unable to replicate the crash from https://github.com/rust-bitcoin/rust-miniscript/runs/3041068605 locally. Creating a upstream to retest the same vector on CI

@sanket1729
Copy link
Member Author

sanket1729 commented Jul 12, 2021

Okay, I have investigated this for a couple of hours. Giving up on this, any ideas appreciated. Maybe it was some random bug in one of the dependencies?

@sanket1729
Copy link
Member Author

Well, now it's passing again. But this is flaky and should be investigated

@apoelstra
Copy link
Member

apoelstra commented Sep 8, 2021

Closing this, we realized that the issue was caused by the rust-secp "fuzztarget" crypto being broken. See rust-bitcoin/rust-secp256k1#264 where I fixed it and rust-bitcoin/rust-secp256k1#282 where Matt re-broke it to improve fuzzability.

I put fixing this on my list of potential intern jobs, it's not trivial to get internally consistent crypto which can still be broken by a fuzzer and which has similar parser behavior to the real libsecp.

@apoelstra apoelstra closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants