Clear trivial clippy warnings
#615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy warns: warning: consider choosing a more descriptive name Cause by an accidental double underscore, remove one of them.
Clippy warns: warning: this expression creates a reference which is immediately dereferenced by the compiler Remove the explicit reference.
Clippy warns: warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` As suggested, use `iter` instead of `into_iter`
Clippy emits: warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` Remove the unnecessary calls to `into_iter()`.
Clippy emits: warning: this lifetime isn't used in the impl As suggested, remove the unneeded lifetime.
Clippy emits: warning: redundant pattern matching, consider using `is_some()` As suggested, use `is_some()`.
Clippy emits: warning: called `is_none()` after searching an `Iterator` with `find` As suggested, use `any` instead.
Clippy emits: warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` As suggested, use `if let`.
Clippy emits: warning: iterating on a map's keys As suggested, use `into_keys`.
Clippy emits: warning: method `add` can be confused for the standard trait method `std::ops::Add::add` Just shoosh clippy.
Clippy emits: warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` As suggested, use `mem::take`.
Clippy emits: warning: digits grouped inconsistently by underscores Add the missing underscore.
Clippy emits: warning: items were found after the testing module While trivial where prelude is placed, clippy does seem correct.
Clippy emits: warning: the borrowed expression implements the required traits As suggested remove the reference.
Clippy emits: warning: useless use of `vec!` As suggested, use a slice instead.
Clippy emits: warning: redundant field names in struct initialization As suggested, remove redundant field name.
Clippy emits: warning: redundant closure As suggested, remove the redundant closure.
Clippy emits:n warning: using `clone` on type `Hash` which implements the `Copy` trait Remove the unnecessary call to clone.
Clippy emits: warning: the loop variable `i` is only used to index `keys` The code is clear as is, ignore this warning.
Clippy emits: warning: the loop variable `idx` is only used to index `serialized_keys` Remove the loop variable, be more Rusty.
Clippy emits: field assignment outside of initializer for an instance created with Default::default() As suggested, use `..Default` to initialize the `TxIn`. While we are at it remove unnecessary comment (looks like it originated as commented out code).
tcharding
force-pushed
the
10-12-clippy
branch
from
f3a1ae3 to
27278a5
Compare
apoelstra
added a commit
that referenced
this pull request
Nov 7, 2023
7eccfdb clippy: whitelist iter_kv lint since it is broken (Andrew Poelstra) 6de288f cargo fmt (Andrew Poelstra) f9c4e53 clippy: fix PartialOrd impl on an Ord type (Andrew Poelstra) 1f8dfe2 clippy: clean up iterator (Andrew Poelstra) 5ab7afe clippy: whitelist inapplicable lints (Andrew Poelstra) 2237906 clippy: use try_fold in place of fold in several places (Andrew Poelstra) 4f7782f clippy: minor things (Andrew Poelstra) a61f71a clippy: eliminate a bunch of redundant `into_iter` calls (Andrew Poelstra) Pull request description: Supercedes #615. ACKs for top commit: tcharding: ACK 7eccfdb sanket1729: ACK 7eccfdb Tree-SHA512: ea4f14f754b07c9ae127684e6ca1d9f121361a7be617d45a19af0269af735d2f420f59abdf15b943052b34cc9afba31cddc87d75a86694f8eefa0d672d4b031b
|
Done fresh in #670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack like I'm a week one contributor again, remove a bunch of trivial lint warnings.
There are a bunch more still, draft till I get them all.