Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add justfile #668

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add justfile #668

merged 1 commit into from
Mar 28, 2024

Conversation

tcharding
Copy link
Member

Add a just config file with various useful commands. Note that a bunch of these commands do not succeed currently on master, specifically:

  • just lint
  • just docsrs
  • just sane

Will fix as separate PRs

Add a `just` config file with various useful commands. Note that a bunch
of these commands do not succeed currently on master, specifically:

- just lint
- just docsrs
- just sane

Will fix as separate PRs
@tcharding
Copy link
Member Author

Tested with #669 and #670 - with those applied all just commands pass.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9f5849f

@apoelstra apoelstra merged commit cbfe991 into rust-bitcoin:master Mar 28, 2024
16 checks passed
apoelstra added a commit that referenced this pull request Mar 29, 2024
7634642 Use struct update syntax (Tobin C. Harding)
2bc083e Use iterator instead of manual loop (Tobin C. Harding)
6d663e1 Allow range loop in test code (Tobin C. Harding)
a8c156e Use map instead of and_then (Tobin C. Harding)
d5662da Remove redundant closure (Tobin C. Harding)
90f1585 Remove redundant clone (Tobin C. Harding)
409d4b0 Remove explicit reference (Tobin C. Harding)
9ec6b17 Remove redundant field names in struct initialization (Tobin C. Harding)

Pull request description:

  After doing #668 I wanted to be able to use the `just sane` command before pushing PRs, so fix the lint issues.

ACKs for top commit:
  apoelstra:
    ACK 7634642 thanks! we should re-enabled Clippy in CI in this repo...I believe we disabled it due to a clippy bug in July

Tree-SHA512: 1e953f2fc1a6e649324293a84abf1be54feca6095111653af046aacf17a83e6ae15452fe8825599ccbfae0ea84fe7d1988c8b72d5dd902c9d0fb1d34e660ef8b
@tcharding tcharding deleted the 03-28-just branch April 1, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants