Fix all lint errors and warnings #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clippy emits: error: redundant field names in struct initialization As suggested, remove redundant field names in struct initialization
clippy emits: error: this expression creates a reference which is immediately dereferenced by the compiler As suggested, remove the explicit reference.
clippy emits two warnings of form: error: using `clone` on type ... which implements the `Copy` trait As suggested, remove redundant call to `clone()`.
clippy emits: error: redundant closure As suggested, remove the redundant closure.
clippy emits: error: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` As suggested, use `map` combinator.
The explicit array access is clear, just shoosh the linter.
Get more Rusty, use iterator instead of array access. While we are at it don't explicitly create the slice, that is a hangover from Rust 1.48
clippy emits: error: field assignment outside of initializer for an instance created with Default::default() Use struct update syntax instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing #668 I wanted to be able to use the
just sanecommand before pushing PRs, so fix the lint issues.