-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #783
base: master
Are you sure you want to change the base?
Update dependencies #783
Conversation
I guess we can move to Can you update the lockfiles included in this crate? You can run |
done |
Thanks! Can you also update the Finally, can I ask that you break this into three commits:
So that we can see the lockfile changes for each one? |
done |
I edited your PR description and title, hope you don't mind. |
I can investigate your CI fail later on today if you like. I'm surprised to see it with these small changes. |
Oh there are re-names that need doing in the docs e.g., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the last commit needs to be merged with the one updating rand
.
@@ -37,7 +37,7 @@ global-context-less-secure = ["global-context"] | |||
secp256k1-sys = { version = "0.11.0", default-features = false, path = "./secp256k1-sys" } | |||
|
|||
hashes = { package = "bitcoin_hashes", version = "0.16", default-features = false, optional = true } | |||
rand = { version = "0.9", default-features = false, optional = true } | |||
rand = { version = "0.9", default-features = false, features = ["thread_rng"], optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't object to his but long term it'd be cool to propagate the feature.
In this github ci , only two failed, but it does not matter with this repo code. |
@getong we have additional policy that each commit separately must pass tests. This is (currently) not checked by Github but @apoelstra has his own CI where he tests it. |
The WASM error I think isn't related to this, but the other CI failure is because you're enabling the std feature of |
I try to add std feature to getrandom, but ci test still failed. So I delete std feature of getrandom. |
Unfortunately you need to explicitly disable it with |
Update dependencies: