Revert cortex-m #605
Open
Revert cortex-m #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cortex-m crate in the master branch is 0.7.4 plus a bunch of fixes that have never been released. Some of them are breaking changes and so will never be released. We cannot 'just' release a cortex-m 0.8 with them in because that is ecosystem shattering - the crate contains a 'links=' attribute, and a bunch of no_mangle functions, so you cannot have two versions in the same dependency tree. Instead, there is a 0.7.x branch. This was taken before the cortex-m-rt crate move. It has cortex-m 0.7.7, which has been published. This commit just deletes the cortex-m folder and replaces it with the contents of the cortex-m crate as found on the the 0.7.x branch. If you want to pick up the changes that have just been deleted, cherry- pick them into a new branch and open a PR to merge them into here. Breaking changes for cortex-m into master will no longer be accepted. Sorry.
Binaries are unchanged.
I don't want lints that tell me to fix things that don't work in the MSRV. Unfortunately I also have to unify the MSRV for cortex-m and cortex-m-rt, raising the cortex-m MSRV to 1.61.
thejpster
force-pushed
the
revert-cortex-m
branch
from
55c559d to
b7101e5
Compare
OK, that seems to be a genuine bug that this annoying new feature caught.
Will avoid a bunch of clippy warnings that are hard to get rid of in both the MSRV and latest stable.
thejpster
force-pushed
the
revert-cortex-m
branch
from
cc57e1d to
ba86f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are in a mess. This PR attempts to fix it.
The cortex-m crate in the master branch is 0.7.4 plus a bunch of fixes that have never been released. Some of them are breaking changes and so will never be released. We cannot 'just' release a cortex-m 0.8 with them in because that is ecosystem shattering - the crate contains a
'links=' attribute, and a bunch of no_mangle functions, so you cannot have two versions in the same dependency tree.
Instead, there is a 0.7.x branch. This was taken before the cortex-m-rt crate move. It has cortex-m 0.7.7, which has been published.
This commit just deletes the
cortex-mfolder and replaces it with the contents of thecortex-mcrate as found on the the 0.7.x branch.If you want to pick up the changes that have just been deleted, cherry-pick them into a new branch and open a PR to merge them into here.
Breaking changes for cortex-m into master will no longer be accepted.
Sorry.