Skip to content

N28: Release #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 9, 2021
Merged

N28: Release #887

merged 15 commits into from
Dec 9, 2021

Conversation

AngelOnFira
Copy link
Member

@AngelOnFira AngelOnFira commented Dec 8, 2021

Part of #852

Netlify Preview (b874f85): https://agitated-saha-af60ca.netlify.app/

Remaining steps:

  • Add discussions links
  • Spelling and grammar pass
  • Final review
  • Publish
  • Posts
  • Comment links

@PsichiX
Copy link
Contributor

PsichiX commented Dec 8, 2021

Rust CUDA seems to have missing link in the title - [Rust CUDA]

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments:

  • The empty sections still need removing (and the corresponding TOC items), and the requests for contribution section needs filling in.
  • Halloween Mahjong Solitaire has some repeated phrasing in the first line:

Halloween Mahjong Solitaire (GitHub) by Syn-Nine is a game created by Syn9 for Game Developers Refuge 4x4x4 Challenge, October 2021.

  • Bendyworm has the dev's name inside the brackets instead of outside.
  • Might it be worth making the 'Raytracer Challenge' image link to the video playlist?

@AngelOnFira
Copy link
Member Author

@ozkriff @17cupsofcoffee I couldn't make a PR on this repo for the other news section, since I made this branch from my fork, so I just merged it and we can request any changes in this PR.

f9f781d

@AngelOnFira
Copy link
Member Author

Going for the merge now, as I think I've more or less gotten an approval from enough parties :)

@AngelOnFira AngelOnFira merged commit 92a1014 into rust-gamedev:source Dec 9, 2021
@AngelOnFira AngelOnFira deleted the n28-release branch December 9, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants