Add prefer_clang_cl_over_msvc

[dennisameling]

Closes #882

This could probably replace #1367. Now that #1506 has been merged, windows_registry_find_tool can find clang-cl.exe correctly.

This PR also adds a fix for something I missed in find_tools as part of #1506: clang_cl should be set to true when using that toolchain.

Lastly, this PR adds some tests to ensure that the logic that @briansmith described here works as expected.

[dennisameling]

The failing tests in CI seem to be caused by ca81dcc, which has the same failing tests on the main branch.

[NobodyXu]

#1426

Confirmed that nightly has removed env in favor of abi, so it's not caused by this PR or that one

[NobodyXu]

Fixed in #1517, just rebasing would fix it

[NobodyXu]

Thanks!

I think you need to modify line 177 to add clang-cl to the array?

[dennisameling]

Looks like some (seemingly unrelated) tests are now failing with:

 thread 'apple_sdkroot_wrong' panicked at tests/support/mod.rs:143:13:
didn't find "/Applications/Xcode_15.4.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS17.5.sdk" in ["-O2", "-fPIC", "--target=arm64-apple-ios", "-miphoneos-version-min=17.5", "-isysroot", "/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk", "-Wall", "-Wextra", "-o", "/Users/runner/work/cc-rs/cc-rs/target/aarch64-apple-darwin/debug/cc-shim-teste6yNGK/db3b6bfb95261072-foo.o", "-c", "foo.c"]
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

... which is interesting because the documentation for macos-14-arm64 shows that the iOS 17.5 SDK should be installed. Any thoughts on this?

[NobodyXu]

It seems that the path to the sdj has changed.

We expect to find /Applications/Xcode_15.4.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS17.5.sdk, but found:

/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk

Maybe we are using the wrong sdk?

[NobodyXu]

Thank you!