Tidying up tests/ui/issues 33 tests [4/N] #149767
Conversation
|
This PR modifies |
rustbot
added
S-waiting-on-review
reddevilmidzy
changed the title
There was a problem hiding this comment.
I'm not sure if there a directory for tests that test a CLI options passed to compiler like in this case
There was a problem hiding this comment.
There was an invalid-compile-flags directory, but no directory like run-pass compile flags
There was a problem hiding this comment.
let's do tests/ui/compile-flags and split it into ui/compile-flags/invalid/ and ui/compile-flags/run-pass/
There was a problem hiding this comment.
It seems like type check something
There was a problem hiding this comment.
moved to tests/ui/typeck/osstring-str-equality.rs
There was a problem hiding this comment.
Yep moved to tests/ui/resolve/module-used-as-struct-constructor.rs
There was a problem hiding this comment.
I feel like it more pattern directory, or even shadowing
There was a problem hiding this comment.
Yes, I moved it to the pattern directory. and the test below moved it to the shadowing directory
There was a problem hiding this comment.
the same as above but it looks like more shadowing
There was a problem hiding this comment.
Oh, I missed it sorry
|
Everything else is fine For the tests amount I would say that 15+- is very comfortable to review If you want to do more that's fine as well, just might take more time but I have nothing against it |
I saw the comment left on another PR. I will change # to link! regex is awesome.. |
|
I'll take a last look before merge tomorrow, sorry for delay |
3 participants
Note
Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.
part of #133895
tests/ui/compile-flagssplit it intotests/ui/compile-flags/invalid/andtests/ui/compile-flags/run-pass/r? Kivooeo