Tidying up tests/ui/issues 33 tests [4/N]

tests/ui/README.md

@@ -256,6 +256,10 @@ Some traits' implementation must be compared with their definition, checking for
 
 This subdirectory is *not* intended comparison traits (`PartialEq`, `Eq`, `PartialOrd`, `Ord`).
 
+## `tests/ui/compile-flags/`
+
+Tests for compile flags.
+
 ## `tests/ui/compiletest-self-test/`: compiletest "meta" tests
 
 Meta test suite of the test harness `compiletest` itself.
@@ -548,6 +552,8 @@ A broad directory for tests on expressions.
 
 Tests on the `extern` keyword and `extern` blocks and functions.
 
+**FIXME**: Merge with `tests/ui/abi/extern`.
+
 ## `tests/ui/extern-flag/`: `--extern` command line flag
 
 Tests for the `--extern` CLI flag.
@@ -556,6 +562,12 @@ Tests for the `--extern` CLI flag.
 
 Tests on feature-gating, and the `#![feature(..)]` mechanism itself.
 
+## `tests/ui/ffi/`: Foreign Function Interface
+
+Tests for the `std::ffi` module.
+
+See [`std::ffi`](https://doc.rust-lang.org/std/ffi/index.html)
+
 ## `tests/ui/ffi-attrs/`: `#![feature(ffi_const, ffi_pure)]`
 
 The `#[ffi_const]` and `#[ffi_pure]` attributes applies clang's `const` and `pure` attributes to foreign functions declarations, respectively. These attributes are the core element of the tests in this category.
@@ -733,15 +745,9 @@ Various tests related to rejecting invalid inputs.
 
 **FIXME**: This is rather uninformative, possibly rehome into more meaningful directories.
 
-## `tests/ui/invalid-compile-flags/`
-
-Tests for checking that invalid usage of compiler flags are rejected.
-
-## `tests/ui/io-checks/`
-
-Contains a single test. The test tries to output a file into an invalid directory with `-o`, then checks that the result is an error, not an internal compiler error.
+## `tests/ui/io-checks/`: Input Output
 
-**FIXME**: Rehome to invalid compiler flags maybe.
+Tests for I/O related behaviour, covering stdout/stderr handling and error propagation.
 
 ## `tests/ui/issues/`: Tests directly related to GitHub issues
 

tests/ui/issues/issue-46472.rs → tests/ui/borrowck/return-ref-to-temporary.rs

@@ -1,6 +1,7 @@
+//! regression test for issue https://github.com/rust-lang/rust/issues/46472
 fn bar<'a>() -> &'a mut u32 {
     &mut 4
     //~^ ERROR cannot return reference to temporary value [E0515]
 }
 
-fn main() { }
+fn main() {}

tests/ui/issues/issue-46472.stderr → tests/ui/borrowck/return-ref-to-temporary.stderr

@@ -1,5 +1,5 @@
 error[E0515]: cannot return reference to temporary value
-  --> $DIR/issue-46472.rs:2:5
+  --> $DIR/return-ref-to-temporary.rs:3:5
    |
 LL |     &mut 4
    |     ^^^^^-

tests/ui/issues/issue-19499.rs → tests/ui/closures/closure-upvar-trait-caching.rs

@@ -7,8 +7,9 @@
 // reasonable examples) let to ambiguity errors about not being able
 // to infer sufficient type information.
 
-
 fn main() {
     let n = 0;
-    let it = Some(1_usize).into_iter().inspect(|_| {n;});
+    let it = Some(1_usize).into_iter().inspect(|_| {
+        n;
+    });
 }

tests/ui/closures/nested-closure-call.rs

@@ -0,0 +1,5 @@
+//! regression test for https://github.com/rust-lang/rust/issues/24779
+//@ run-pass
+fn main() {
+    assert_eq!((|| || 42)()(), 42);
+}

tests/ui/issues/issue-24945-repeat-dash-opts.rs → tests/ui/compile-flags/run-pass/repeated-debug-opt-flags.rs

@@ -1,3 +1,4 @@
+//! regression test for https://github.com/rust-lang/rust/issues/24945
 //@ run-pass
 // This test is just checking that we continue to accept `-g -g -O -O`
 // as options to the compiler.

tests/ui/enum/enum-variant-no-field.rs

@@ -0,0 +1,9 @@
+//! regression test for https://github.com/rust-lang/rust/issues/23253
+enum Foo {
+    Bar,
+}
+
+fn main() {
+    Foo::Bar.a;
+    //~^ ERROR no field `a` on type `Foo`
+}

tests/ui/issues/issue-23253.stderr → tests/ui/enum/enum-variant-no-field.stderr

@@ -1,5 +1,5 @@
 error[E0609]: no field `a` on type `Foo`
-  --> $DIR/issue-23253.rs:4:14
+  --> $DIR/enum-variant-no-field.rs:7:14
    |
 LL |     Foo::Bar.a;
    |              ^ unknown field

tests/ui/issues/issue-50442.rs → tests/ui/enum/enum-with-uninhabited-variant.rs

@@ -1,11 +1,12 @@
+//! regression test for issue https://github.com/rust-lang/rust/issues/50442
 //@ run-pass
 #![allow(dead_code)]
 enum Void {}
 
 enum Foo {
     A(i32),
     B(Void),
-    C(i32)
+    C(i32),
 }
 
 fn main() {

tests/ui/expr/return-in-block-tuple.rs

@@ -0,0 +1,7 @@
+//! regression test for https://github.com/rust-lang/rust/issues/18110
+//@ run-pass
+#![allow(unreachable_code)]
+
+fn main() {
+    ({ return },);
+}

tests/ui/issues/issue-19398.rs → tests/ui/extern/extern-rust-trait-method.rs

@@ -1,3 +1,4 @@
+//! Regression test for https://github.com/rust-lang/rust/issues/19398
 //@ check-pass
 
 trait T {

tests/ui/fmt/println-float.rs

@@ -0,0 +1,5 @@
+//! regression test for https://github.com/rust-lang/rust/issues/11382
+//@ run-pass
+fn main() {
+    println!("{}", 1.2);
+}

tests/ui/indexing/ref-array-indexing.rs

@@ -0,0 +1,6 @@
+//! regression test for https://github.com/rust-lang/rust/issues/43205
+//@ run-pass
+fn main() {
+    let _ = &&[()][0];
+    println!("{:?}", &[(), ()][1]);
+}

tests/ui/issues/issue-17758.rs → tests/ui/lifetimes/trait-method-lifetime-suggestion.rs

@@ -1,5 +1,6 @@
-// Test that regionck suggestions in a provided method of a trait
-// don't ICE
+//! regression test for https://github.com/rust-lang/rust/issues/17758
+//! Test that regionck suggestions in a provided method of a trait
+//! don't ICE
 
 trait Foo<'a> {
     fn foo(&'a self);

tests/ui/issues/issue-17758.stderr → tests/ui/lifetimes/trait-method-lifetime-suggestion.stderr

@@ -1,5 +1,5 @@
 error: lifetime may not live long enough
-  --> $DIR/issue-17758.rs:7:9
+  --> $DIR/trait-method-lifetime-suggestion.rs:8:9
    |
 LL | trait Foo<'a> {
    |           -- lifetime `'a` defined here

tests/ui/lint/lint-missing-doc-crate-attr.rs

@@ -0,0 +1,4 @@
+// regression test for https://github.com/rust-lang/rust/issues/10656
+#![deny(missing_docs)]
+//~^ ERROR missing documentation for the crate
+#![crate_type = "lib"]

tests/ui/issues/issue-10656.stderr → tests/ui/lint/lint-missing-doc-crate-attr.stderr

@@ -1,12 +1,13 @@
 error: missing documentation for the crate
-  --> $DIR/issue-10656.rs:1:1
+  --> $DIR/lint-missing-doc-crate-attr.rs:2:1
    |
 LL | / #![deny(missing_docs)]
-LL | | #![crate_type="lib"]
-   | |____________________^
+LL | |
+LL | | #![crate_type = "lib"]
+   | |______________________^
    |
 note: the lint level is defined here
-  --> $DIR/issue-10656.rs:1:9
+  --> $DIR/lint-missing-doc-crate-attr.rs:2:9
    |
 LL | #![deny(missing_docs)]
    |         ^^^^^^^^^^^^

tests/ui/lint/lint-missing-doc-crate.stderr → tests/ui/lint/lint-missing-doc-crate-flags.stderr

@@ -1,5 +1,5 @@
 error: missing documentation for the crate
-  --> $DIR/lint-missing-doc-crate.rs:4:47
+  --> $DIR/lint-missing-doc-crate-flags.rs:4:47
    |
 LL |
    |                                              ^

tests/ui/issues/issue-19734.rs → tests/ui/macros/undefined-macro-in-impl.rs

@@ -1,3 +1,4 @@
+//! regression test for https://github.com/rust-lang/rust/issues/19734
 fn main() {}
 
 struct Type;

tests/ui/issues/issue-19734.stderr → tests/ui/macros/undefined-macro-in-impl.stderr

@@ -1,5 +1,5 @@
 error: cannot find macro `undef` in this scope
-  --> $DIR/issue-19734.rs:6:5
+  --> $DIR/undefined-macro-in-impl.rs:7:5
    |
 LL |     undef!();
    |     ^^^^^

tests/ui/match/match-const-tuple-type-mismatch.rs

@@ -0,0 +1,13 @@
+//! Regression test for issue https://github.com/rust-lang/rust/issues/4968
+//@ dont-require-annotations: NOTE
+
+const A: (isize, isize) = (4, 2);
+fn main() {
+    match 42 {
+        A => (),
+        //~^ ERROR mismatched types
+        //~| NOTE expected type `{integer}`
+        //~| NOTE found tuple `(isize, isize)`
+        //~| NOTE expected integer, found `(isize, isize)`
+    }
+}

tests/ui/match/match-const-tuple-type-mismatch.stderr

@@ -0,0 +1,21 @@
+error[E0308]: mismatched types
+  --> $DIR/match-const-tuple-type-mismatch.rs:7:9
+   |
+LL | const A: (isize, isize) = (4, 2);
+   | ----------------------- constant defined here
+LL | fn main() {
+LL |     match 42 {
+   |           -- this expression has type `{integer}`
+LL |         A => (),
+   |         ^
+   |         |
+   |         expected integer, found `(isize, isize)`
+   |         `A` is interpreted as a constant, not a new binding
+   |         help: introduce a new binding instead: `other_a`
+   |
+   = note: expected type `{integer}`
+             found tuple `(isize, isize)`
+
+error: aborting due to 1 previous error
+
+For more information about this error, try `rustc --explain E0308`.