Skip to content

refactor: reduce complexity#6182

Open
lisalupi wants to merge 3 commits intomainfrom
chore/complexity
Open

refactor: reduce complexity#6182
lisalupi wants to merge 3 commits intomainfrom
chore/complexity

Conversation

@lisalupi
Copy link
Collaborator

@lisalupi lisalupi commented Mar 5, 2026

Summary

Type

  • Refactor

Summarize concisely:

What is expected?

Refactor some components to reduce complexity (oxlint/biome), improve legibility, reduce repetitive code, have only 1 component/file.

Before After
Biome Capture d’écran 2026-03-06 à 11 31 23 Capture d’écran 2026-03-11 à 14 49 17
OXC Capture d’écran 2026-03-11 à 15 08 33 Capture d’écran 2026-03-11 à 15 06 15
OXC type aware Capture d’écran 2026-03-11 à 15 09 17 Capture d’écran 2026-03-11 à 15 07 15

@lisalupi lisalupi self-assigned this Mar 5, 2026
@lisalupi lisalupi added the refactor Refactor without breaking changes label Mar 5, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2026

⚠️ No Changeset found

Latest commit: a6b461b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 88.83610% with 141 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.45%. Comparing base (bb85800) to head (a6b461b).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/Popup/helpers.ts 75.00% 19 Missing and 4 partials ⚠️
...i/src/components/Expandable/AnimatedExpandable.tsx 62.22% 14 Missing and 3 partials ⚠️
...ages/ui/src/components/Modal/components/Dialog.tsx 6.25% 10 Missing and 5 partials ⚠️
...nents/SelectInput/components/Dropdown/Dropdown.tsx 87.96% 10 Missing and 3 partials ⚠️
...i/src/components/SelectInput/components/helpers.ts 84.09% 7 Missing ⚠️
...s/ui/src/components/TextInput/ShowHidePassword.tsx 12.50% 7 Missing ⚠️
...mpositions/Navigation/components/Item/Children.tsx 73.91% 6 Missing ⚠️
...nts/SelectInput/components/SelectBar/SelectBar.tsx 95.09% 5 Missing ⚠️
...ckages/ui/src/components/List/ExpandButtonCell.tsx 55.55% 4 Missing ⚠️
packages/ui/src/components/Menu/MenuContent.tsx 85.18% 4 Missing ⚠️
... and 20 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6182      +/-   ##
==========================================
+ Coverage   92.12%   92.45%   +0.33%     
==========================================
  Files         462      523      +61     
  Lines        9661     9687      +26     
  Branches     3878     3800      -78     
==========================================
+ Hits         8900     8956      +56     
+ Misses        690      667      -23     
+ Partials       71       64       -7     
Files with missing lines Coverage Δ
packages/ui/src/components/Button/index.tsx 96.29% <ø> (ø)
packages/ui/src/components/Checkbox/index.tsx 100.00% <100.00%> (+3.33%) ⬆️
.../components/DateInput/components/CalendarDaily.tsx 100.00% <100.00%> (ø)
...omponents/DateInput/components/CalendarMonthly.tsx 100.00% <100.00%> (ø)
...rc/components/Expandable/NonAnimatedExpandable.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Expandable/constant.ts 100.00% <100.00%> (ø)
packages/ui/src/components/Expandable/index.tsx 100.00% <ø> (+30.90%) ⬆️
...ackages/ui/src/components/ExpandableCard/index.tsx 88.60% <ø> (ø)
...es/ui/src/components/FileInput/DropzoneContent.tsx 100.00% <100.00%> (ø)
...es/ui/src/components/FileInput/components/List.tsx 100.00% <100.00%> (ø)
... and 120 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce6e86...a6b461b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lisalupi lisalupi force-pushed the chore/complexity branch 2 times, most recently from e28c25c to e11023f Compare March 11, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor without breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants