Skip to content

refactor: reduce complexity #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lisalupi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: reduce complexity #6182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48c8262
refactor: select input complexity
lisalupi Mar 5, 2026
cf7d488
refactor: reduce more complexities
lisalupi Mar 6, 2026
a6b461b
refactor: more refacto
lisalupi Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/next/src/pages/login/login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ const LogIn = () => {
)
setTimeout(() => setLoginText(''), 3000)

// oxlint-disable-next-line eslint/no-console
console.log('Values :', values)
}

Expand Down
1 change: 0 additions & 1 deletion examples/vite/src/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { StrictMode } from 'react'
import { createRoot } from 'react-dom/client'
import { App } from './App.tsx'

// biome-ignore lint/style/noNonNullAssertion: not an error
const root = createRoot(document.getElementById('root')!)

root.render(
Expand Down
369 changes: 182 additions & 187 deletions packages/form/src/components/DateInputField/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop

Large diffs are not rendered by default.

104 changes: 52 additions & 52 deletions packages/form/src/components/SelectInputField/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions ...src/components/SelectableCardOptionGroupField/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
<div
aria-controls="_r_7_"
aria-expanded="false"
class="uv_1ba7knd6 uv_1ba7knd5 uv_1ba7kndb uv_1ba7knde"
class="uv_r8qe46 uv_r8qe45 uv_r8qe4b uv_r8qe4e"
data-disabled="false"
data-readonly="false"
data-testid="select-input-selectable-card-option"
Expand All @@ -145,12 +145,12 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
tabindex="0"
>
<span
class="uv_1ba7kndm uv_m4c9ow0 uv_m4c9ow4 uv_m4c9owb uv_m4c9owk uv_m4c9ow1a uv_m4c9ow32"
class="uv_r8qe4m uv_m4c9ow0 uv_m4c9ow4 uv_m4c9owb uv_m4c9owk uv_m4c9ow1a uv_m4c9ow32"
>
Ubuntu 20.04 Focal Fossa
</span>
<div
class="uv_1ba7knd3 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
class="uv_r8qe43 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
>
<svg
aria-label="show dropdown"
Expand Down Expand Up @@ -284,7 +284,7 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
<div
aria-controls="_r_h_"
aria-expanded="false"
class="uv_1ba7knd6 uv_1ba7knd5 uv_1ba7kndb uv_1ba7knde"
class="uv_r8qe46 uv_r8qe45 uv_r8qe4b uv_r8qe4e"
data-disabled="false"
data-readonly="false"
data-testid="select-input-selectable-card-option"
Expand All @@ -293,12 +293,12 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
tabindex="0"
>
<span
class="uv_1ba7knd4 uv_m4c9ow0 uv_m4c9ow7 uv_m4c9owb uv_m4c9owk uv_m4c9ow1d uv_m4c9ow35"
class="uv_r8qe44 uv_m4c9ow0 uv_m4c9ow7 uv_m4c9owb uv_m4c9owk uv_m4c9ow1d uv_m4c9ow35"
>
Select item
</span>
<div
class="uv_1ba7knd3 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
class="uv_r8qe43 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
>
<svg
aria-label="show dropdown"
Expand Down Expand Up @@ -432,7 +432,7 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
<div
aria-controls="_r_r_"
aria-expanded="false"
class="uv_1ba7knd6 uv_1ba7knd5 uv_1ba7kndb uv_1ba7knde"
class="uv_r8qe46 uv_r8qe45 uv_r8qe4b uv_r8qe4e"
data-disabled="false"
data-readonly="false"
data-testid="select-input-selectable-card-option"
Expand All @@ -441,12 +441,12 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
tabindex="0"
>
<span
class="uv_1ba7knd4 uv_m4c9ow0 uv_m4c9ow7 uv_m4c9owb uv_m4c9owk uv_m4c9ow1d uv_m4c9ow35"
class="uv_r8qe44 uv_m4c9ow0 uv_m4c9ow7 uv_m4c9owb uv_m4c9owk uv_m4c9ow1d uv_m4c9ow35"
>
Select item
</span>
<div
class="uv_1ba7knd3 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
class="uv_r8qe43 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
>
<svg
aria-label="show dropdown"
Expand Down
36 changes: 17 additions & 19 deletions packages/form/src/components/Submit/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,23 @@ exports[`submit > form is invalid 1`] = `
>
test
</label>
<div>
<div
class="uv_q3q8048 uv_q3q8045"
data-disabled="false"
data-error="false"
data-has-focus="false"
data-readonly="false"
data-success="false"
>
<input
aria-invalid="false"
class="uv_q3q8049"
data-size="large"
id="_r_1_"
name="toto"
type="text"
value="4"
/>
</div>
<div
class="uv_q3q8048 uv_q3q8045"
data-disabled="false"
data-error="false"
data-has-focus="false"
data-readonly="false"
data-success="false"
>
<input
aria-invalid="false"
class="uv_q3q8049"
data-size="large"
id="_r_1_"
name="toto"
type="text"
value="4"
/>
</div>
</div>
<button
Expand Down
110 changes: 53 additions & 57 deletions packages/form/src/components/TextInputField/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,23 @@ exports[`textInputField > should render correctly 1`] = `
>
Test
</label>
<div>
<div
class="uv_q3q8048 uv_q3q8045"
data-disabled="false"
data-error="false"
data-has-focus="false"
data-readonly="false"
data-success="false"
>
<input
aria-invalid="false"
class="uv_q3q8049"
data-size="large"
id="_r_0_"
name="test"
type="text"
value=""
/>
</div>
<div
class="uv_q3q8048 uv_q3q8045"
data-disabled="false"
data-error="false"
data-has-focus="false"
data-readonly="false"
data-success="false"
>
<input
aria-invalid="false"
class="uv_q3q8049"
data-size="large"
id="_r_0_"
name="test"
type="text"
value=""
/>
</div>
</div>
</form>
Expand Down Expand Up @@ -71,48 +69,46 @@ exports[`textInputField > should render correctly generated 1`] = `
*
</span>
</div>
<div>
<div
class="uv_q3q8048 uv_q3q8045"
data-disabled="false"
data-error="false"
data-has-focus="false"
data-readonly="false"
data-success="false"
>
<input
aria-invalid="false"
class="uv_q3q8049"
data-size="large"
id="_r_3_"
name="test"
required=""
type="text"
value="This is an example"
/>
<div
class="uv_q3q8048 uv_q3q8045"
data-disabled="false"
data-error="false"
data-has-focus="false"
data-readonly="false"
data-success="false"
class="uv_q3q8042 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
>
<input
aria-invalid="false"
class="uv_q3q8049"
data-size="large"
id="_r_3_"
name="test"
required=""
type="text"
value="This is an example"
/>
<div
class="uv_q3q8042 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
<button
aria-label="clear value"
class="uv_e1wcoe0 uv_e1wcoe1 uv_e1wcoe3 uv_e1wcoe8 uv_e1wcoeg uv_e1wcoej uv_e1wcoe19"
type="button"
>
<button
aria-label="clear value"
class="uv_e1wcoe0 uv_e1wcoe1 uv_e1wcoe3 uv_e1wcoe8 uv_e1wcoeg uv_e1wcoej uv_e1wcoe19"
type="button"
<svg
class="uv_icons_1sbwqkz0 uv_icons_1sbwqkz1 uv_icons_1sbwqkz3 uv_icons_1sbwqkzg uv_icons_1sbwqkz1n"
height="16"
viewBox="0 0 16 16"
width="16"
>
<svg
class="uv_icons_1sbwqkz0 uv_icons_1sbwqkz1 uv_icons_1sbwqkz3 uv_icons_1sbwqkzg uv_icons_1sbwqkz1n"
height="16"
viewBox="0 0 16 16"
width="16"
>
<title>
CloseIcon
</title>
<path
d="M5.28 4.22a.75.75 0 0 0-1.06 1.06L6.94 8l-2.72 2.72a.75.75 0 1 0 1.06 1.06L8 9.06l2.72 2.72a.75.75 0 1 0 1.06-1.06L9.06 8l2.72-2.72a.75.75 0 0 0-1.06-1.06L8 6.94z"
/>
</svg>
</button>
</div>
<title>
CloseIcon
</title>
<path
d="M5.28 4.22a.75.75 0 0 0-1.06 1.06L6.94 8l-2.72 2.72a.75.75 0 1 0 1.06 1.06L8 9.06l2.72 2.72a.75.75 0 1 0 1.06-1.06L9.06 8l2.72-2.72a.75.75 0 0 0-1.06-1.06L8 6.94z"
/>
</svg>
</button>
</div>
</div>
</div>
Expand Down
12 changes: 6 additions & 6 deletions packages/form/src/components/UnitInputField/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ exports[`unitInputField > should handles onChange and selection 1`] = `
<div
aria-controls="_r_b_"
aria-expanded="false"
class="uv_1ba7knd6 uv_1ba7knd5 uv_1ba7knda uv_1ba7knde"
class="uv_r8qe46 uv_r8qe45 uv_r8qe4a uv_r8qe4e"
data-disabled="false"
data-readonly="false"
data-testid="select-input-test-unit"
Expand All @@ -76,12 +76,12 @@ exports[`unitInputField > should handles onChange and selection 1`] = `
tabindex="0"
>
<span
class="uv_1ba7kndm uv_m4c9ow0 uv_m4c9ow4 uv_m4c9owb uv_m4c9owj uv_m4c9ow1a uv_m4c9ow32"
class="uv_r8qe4m uv_m4c9ow0 uv_m4c9ow4 uv_m4c9owb uv_m4c9owj uv_m4c9ow1a uv_m4c9ow32"
>
Days
</span>
<div
class="uv_1ba7knd2 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
class="uv_r8qe42 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
>
<svg
aria-label="show dropdown"
Expand Down Expand Up @@ -173,7 +173,7 @@ exports[`unitInputField > should render correctly 1`] = `
<div
aria-controls="_r_3_"
aria-expanded="false"
class="uv_1ba7knd6 uv_1ba7knd5 uv_1ba7knda uv_1ba7knde"
class="uv_r8qe46 uv_r8qe45 uv_r8qe4a uv_r8qe4e"
data-disabled="false"
data-readonly="false"
data-testid="select-input-test-unit"
Expand All @@ -182,12 +182,12 @@ exports[`unitInputField > should render correctly 1`] = `
tabindex="0"
>
<span
class="uv_1ba7knd4 uv_m4c9ow0 uv_m4c9ow7 uv_m4c9owb uv_m4c9owj uv_m4c9ow1d uv_m4c9ow35"
class="uv_r8qe44 uv_m4c9ow0 uv_m4c9ow7 uv_m4c9owb uv_m4c9owj uv_m4c9ow1d uv_m4c9ow35"
>
Select item
</span>
<div
class="uv_1ba7knd2 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
class="uv_r8qe42 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u31 uv_toi52u3p uv_toi52u5v"
>
<svg
aria-label="show dropdown"
Expand Down
Loading
Loading