infrastrucutre test cases#1074
Closed
samarthgupta1 wants to merge 2 commits intosimplcommerce:masterfrom
Closed
Conversation
Author
|
cannot merge it |
hishamco
requested changes
Jan 9, 2024
Member
hishamco
left a comment
hishamco
left a comment
There was a problem hiding this comment.
Please format and remove unnecessary comments
| { | ||
| "ConnectionStrings": { | ||
| "DefaultConnection": "Server=.;Database=SimplCommerce;Trusted_Connection=True;TrustServerCertificate=true;MultipleActiveResultSets=true" | ||
| "DefaultConnection": "server=DotNetFSD\\SQLEXPRESS; database=SimplCommerce; user id=sa; password=pass@123;trustservercertificate=true", |
| @@ -0,0 +1 @@ | |||
| No newline at end of file | |||
Comment on lines
+8
to
+10
| using SimplCommerce.Infrastructure.Helpers; | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Suggested change
| using SimplCommerce.Infrastructure.Helpers; | |
| using SimplCommerce.Infrastructure.Helpers; | |
| } | ||
|
|
||
| [Fact] | ||
| public void IsZeroDecimalCurrencies_WithUnknownCurrency_ReturnsFalse() |
Member
There was a problem hiding this comment.
You could use Theory for the above tests instead of Fact
| Assert.False(result); | ||
| } | ||
| [Fact] | ||
| public void IsZeroDecimalCurrencies_WithUnknown2Currency_ReturnsFalse() |
| Assert.False(result); | ||
|
|
||
| } | ||
|
|
| Assert.True(createdMenu.IsPublished); | ||
| } | ||
|
|
||
|
|
| using Xunit; | ||
|
|
||
| namespace SimplCommerce.Module.Core.Tests.Components | ||
| /*namespace SimplCommerce.Module.Core.Tests.Components |
|
@samarthgupta1 I had resolved all the comments and rebased of your PR but I didn't had access to write in you fork so I have created a new PR with all the resolved comments addressed and added the method documentation also. Attaching the PR link: |
Member
|
Closing this in favor of #1128. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have written remaining test cases for infrastructure module and some for Cms module1: