test: added test cases for helper classes#1128
Merged
hishamco merged 2 commits intosimplcommerce:masterfrom Apr 4, 2025
Merged
test: added test cases for helper classes#1128hishamco merged 2 commits intosimplcommerce:masterfrom
hishamco merged 2 commits intosimplcommerce:masterfrom
Conversation
hishamco
requested changes
Apr 3, 2025
| <TargetFramework>net8.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
|
|
Comment on lines
+12
to
+14
| /// <summary> | ||
| /// Contains unit tests for <see cref="CurrencyHelper.IsZeroDecimalCurrencies"/> method. | ||
| /// </summary> |
Member
There was a problem hiding this comment.
Suggested change
| /// <summary> | |
| /// Contains unit tests for <see cref="CurrencyHelper.IsZeroDecimalCurrencies"/> method. | |
| /// </summary> |
Member
There was a problem hiding this comment.
No need for docs in test projects
Comment on lines
+17
to
+19
| /// <summary> | ||
| /// Verifies that zero-decimal currencies are correctly identified. | ||
| /// </summary> |
Member
There was a problem hiding this comment.
Suggested change
| /// <summary> | |
| /// Verifies that zero-decimal currencies are correctly identified. | |
| /// </summary> |
Comment on lines
+37
to
+39
| /// <summary> | ||
| /// Verifies that an exception is thrown when an invalid culture is provided. | ||
| /// </summary> |
Member
There was a problem hiding this comment.
Suggested change
| /// <summary> | |
| /// Verifies that an exception is thrown when an invalid culture is provided. | |
| /// </summary> |
Comment on lines
+11
to
+13
| /// <summary> | ||
| /// Contains unit tests for <see cref="ReflectionHelperTests"/> method. | ||
| /// </summary> |
Member
There was a problem hiding this comment.
Suggested change
| /// <summary> | |
| /// Contains unit tests for <see cref="ReflectionHelperTests"/> method. | |
| /// </summary> |
Comment on lines
+17
to
+19
| /// <summary> | ||
| /// Contains unit tests for <see cref="MenuApiController"/> method. | ||
| /// </summary> |
Member
There was a problem hiding this comment.
Suggested change
| /// <summary> | |
| /// Contains unit tests for <see cref="MenuApiController"/> method. | |
| /// </summary> |
Author
|
@hishamco comments resolved, PR is ready for review, thanks. |
hishamco
approved these changes
Apr 4, 2025
Member
|
Thanks for your contributions @KaranChadha10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the following points
Added unit tests for the following files=>
Related PR: #1074