Implement Display for nested shapes referenced in error messages #4081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where shapes annotated with
@error
can reference other complex shapes in theirmessage
fields, which previously lackedDisplay
implementations.Changes
AddSyntheticTraitForImplDisplay
) to identify all shapes reachable from error shapesDisplay
implementationsDisplay
for all shapes reachable from error shapesDisplay
implementation for nested error structuresImplementation Details
@error
traitOption<T>
valuesTesting
Fixes #4080