Update to ESLint 9 #2326
Update to ESLint 9 #2326
Conversation
This finally removes the tslint dependency and switches to eslint. There are a lot of other changes here, too, to bring the codebase up to server standards. TSLint never had much in the way of indentation enforcement. Not very happy about eslint splitting itself up over 6 dependencies, or its documentation over three websites, nor how poorly documented the new flat config is, but I mean, eslint's gonna eslint. Customizing would be even harder if we tried to use Biome or something. They mostly seem to go full Prettier.
|
TODO:
|
|
Removing the trailing object commas from |
At the point we originally decided to go ES3, it was for Safari 5 (the last Safari version supported by the iPad 1). Now? I don't even know. A while ago someone showed off PS running on their refrigerator. We've always tried to support ES3 and the broken eslint config was the only reason we hadn't already, so we might as well. New code should mostly be in the TS files, where ES3 support isn't actually difficult. |
|
Being able to lint with |
Also rearrange the config a little.
This also fixes that we weren't extending recommendedTypeChecked, which meant a lot of unnecessary type assertions getting cleaned up.
|
|
(See also smogon/pokemon-showdown#10926 )
This finally removes the tslint dependency and switches to eslint.
There are a lot of other changes here, too, to bring the codebase up to server standards. TSLint never had much in the way of indentation enforcement.
Not very happy about eslint splitting itself up over 6 dependencies, or its documentation over three websites, nor how poorly documented the new flat config is, but I mean, eslint's gonna eslint. Customizing would be even harder if we tried to use Biome or something. They mostly seem to go full Prettier.