Skip to content

fix: Revert "fix: update tmp dependency to solve CVE-2026-44705"#6875

Merged
robertolopezlopez merged 1 commit into
mainfrom
fix/CLI-1550
Jun 4, 2026
Merged

fix: Revert "fix: update tmp dependency to solve CVE-2026-44705"#6875
robertolopezlopez merged 1 commit into
mainfrom
fix/CLI-1550

Conversation

@robertolopezlopez
Copy link
Copy Markdown
Contributor

@robertolopezlopez robertolopezlopez commented Jun 2, 2026

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

  • Revert the override from previous merge.
  • Upgrade production packages which depend on the outdated tmp package
  • Added an override for snyk-python-plugin which installs tmp@0.2.6 in case this dependency is affected by CVE-2026-44705

Where should the reviewer start?

How should this be manually tested?

What's the product update that needs to be communicated to CLI users?

@robertolopezlopez robertolopezlopez requested a review from a team as a code owner June 2, 2026 15:48
@robertolopezlopez robertolopezlopez self-assigned this Jun 2, 2026
@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Jun 2, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

Comment thread package-lock.json
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertolopezlopez Why is this diff so big? Did you use a different NodeJs version?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI also has a few weird failures, I think something is not right.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this diff so big? Did you use a different NodeJs version?

image

v22.22.2 as stated in .nvmrc. I have not added anything package-lock.json apart from what npm install did.

CI also has a few weird failures

Yes, I have seen those strange errors and do not really understand the reason :-/

Copy link
Copy Markdown
Contributor Author

@robertolopezlopez robertolopezlopez Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big diff may be related to the version bump for @snyk/snyk-hex-plugin and snyk-go-plugin

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try to regenerate this again? I did the same changes locally to the package.json file and I got this diff for the lockfile, which I think makes more sense. The +7.8k -5.5k sounds too big for just 2-3 dependency changes (also most of them are minor updates).

Image

Copy link
Copy Markdown
Contributor Author

@robertolopezlopez robertolopezlopez Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird enough, I applied the same commands once again and got much smaller diff. Still, not the +46-10 you got

image

So what are you doing exactly? Which node.js version? Thanks

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
  • Checkout main
  • Apply the same changes to package.json as this PR
  • npm i
  • The diff I get is +46 -10, and it makes sense - just minor bumps and 3 lockfile additions for some dev dependencies that were being overwritten previously.

Comment thread package.json
"minimatch@^3.1.2": "3.1.3",
"tmp": "0.2.7",
"snyk-python-plugin": {
"tmp@<0.2.6": "^0.2.6"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding this override here until snyk-python-plugin will be fixed upstream

@robertolopezlopez
Copy link
Copy Markdown
Contributor Author

robertolopezlopez commented Jun 4, 2026 via email

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 Security concerns

Sensitive information exposure:
Reverting the global tmp version override re-introduces tmp@0.0.33. This version is known to be vulnerable to race conditions in temporary file creation (CVE-2026-44705), which can lead to local privilege escalation or sensitive data access if an attacker can predict or manipulate the temporary file path.

⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 7 relevant code sections from 2 files (average relevance: 0.61)

🤖 Repository instructions applied (from AGENTS.md)

@robertolopezlopez robertolopezlopez merged commit 08381bd into main Jun 4, 2026
8 checks passed
@robertolopezlopez robertolopezlopez deleted the fix/CLI-1550 branch June 4, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants