Skip to content

fix: Revert "fix: update tmp dependency to solve CVE-2026-44705" #6875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertolopezlopez merged 1 commit into from
Jun 4, 2026
+51 −13
Merged

fix: Revert "fix: update tmp dependency to solve CVE-2026-44705" #6875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 46 additions & 10 deletions package-lock.json
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@CatalinSnyk CatalinSnyk Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertolopezlopez Why is this diff so big? Did you use a different NodeJs version?

Copy link
Copy Markdown
Contributor

@CatalinSnyk CatalinSnyk Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI also has a few weird failures, I think something is not right.

Copy link
Copy Markdown
Contributor Author

@robertolopezlopez robertolopezlopez Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this diff so big? Did you use a different NodeJs version?

image

v22.22.2 as stated in .nvmrc. I have not added anything package-lock.json apart from what npm install did.

CI also has a few weird failures

Yes, I have seen those strange errors and do not really understand the reason :-/

Copy link
Copy Markdown
Contributor Author

@robertolopezlopez robertolopezlopez Jun 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big diff may be related to the version bump for @snyk/snyk-hex-plugin and snyk-go-plugin

Copy link
Copy Markdown
Contributor

@CatalinSnyk CatalinSnyk Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try to regenerate this again? I did the same changes locally to the package.json file and I got this diff for the lockfile, which I think makes more sense. The +7.8k -5.5k sounds too big for just 2-3 dependency changes (also most of them are minor updates).

Image

Copy link
Copy Markdown
Contributor Author

@robertolopezlopez robertolopezlopez Jun 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird enough, I applied the same commands once again and got much smaller diff. Still, not the +46-10 you got

image

So what are you doing exactly? Which node.js version? Thanks

Copy link
Copy Markdown
Contributor

@CatalinSnyk CatalinSnyk Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
  • Checkout main
  • Apply the same changes to package.json as this PR
  • npm i
  • The diff I get is +46 -10, and it makes sense - just minor bumps and 3 lockfile additions for some dev dependencies that were being overwritten previously.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"@snyk/fix": "file:packages/snyk-fix",
"@snyk/gemfile": "1.2.0",
"@snyk/snyk-cocoapods-plugin": "3.1.0",
"@snyk/snyk-hex-plugin": "2.1.0",
"@snyk/snyk-hex-plugin": "2.1.1",
"@types/marked": "^4.0.0",
"abbrev": "^1.1.1",
"adm-zip": "^0.5.9",
Expand Down Expand Up @@ -116,7 +116,7 @@
"snyk-config": "^5.0.0",
"snyk-cpp-plugin": "^2.24.3",
"snyk-docker-plugin": "9.7.0",
"snyk-go-plugin": "2.1.1",
"snyk-go-plugin": "2.1.2",
"snyk-gradle-plugin": "7.0.0",
"snyk-module": "3.1.0",
"snyk-mvn-plugin": "^4.7.0",
Expand Down Expand Up @@ -190,7 +190,9 @@
"overrides": {
"cross-spawn@7.0.3": "7.0.6",
"minimatch@^3.1.2": "3.1.3",
"tmp": "0.2.7",
"snyk-python-plugin": {
"tmp@<0.2.6": "^0.2.6"
Copy link
Copy Markdown
Contributor Author

@robertolopezlopez robertolopezlopez Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding this override here until snyk-python-plugin will be fixed upstream

},
"@yarnpkg/core@4.5.0": {
"tar": "7.5.11"
},
Expand Down
Loading