Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECDSAMetaTransactionContext #290

Draft
wants to merge 43 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
a6d7b71
Merge branch 'crypto-improvements' into ecdsa-context
ItsNickBarry Mar 20, 2025
c9c3e70
remove view restriction from context functions
ItsNickBarry Mar 20, 2025
66061bd
Merge branch 'msg-sender-trick' into ecdsa-context
ItsNickBarry Mar 20, 2025
be3f803
Merge branch 'msg-sender-trick' into ecdsa-context
ItsNickBarry Mar 20, 2025
670d4fc
Merge branch 'msg-sender-trick' into ecdsa-context
ItsNickBarry Mar 20, 2025
d36ebea
remove view restrictions from functions that call context functions
ItsNickBarry Mar 20, 2025
26137ac
set evmVerion to cancun
ItsNickBarry Mar 20, 2025
a7510d4
add draft ECDSAMetaTransactionContext contracts
ItsNickBarry Mar 20, 2025
00776de
Merge branch 'msg-sender-trick' into ecdsa-context
ItsNickBarry Mar 20, 2025
b185260
use non-reverting recover for ECDSA context
ItsNickBarry Mar 20, 2025
4d633a0
fix _eip712Domain output
ItsNickBarry Mar 20, 2025
214fff9
Merge branch 'crypto-improvements' into ecdsa-context
ItsNickBarry Mar 20, 2025
5bef448
reference ERC5267 fields constant in ECDSAMetaTransactionContext
ItsNickBarry Mar 20, 2025
32e632d
fix hash struct procedure
ItsNickBarry Mar 20, 2025
86662f6
test ECDSAMetaTransactionContext
ItsNickBarry Mar 20, 2025
be59343
fix test nesting
ItsNickBarry Mar 20, 2025
054d056
use semi-standardized transient storage slot
ItsNickBarry Mar 20, 2025
6087a18
support msg.value in ECDSAMetaTransactionContext
ItsNickBarry Mar 20, 2025
e71e5e9
add failing nonce revert tests
ItsNickBarry Mar 20, 2025
d1169a5
test incorrect msg.value
ItsNickBarry Mar 20, 2025
c88d411
fix comment
ItsNickBarry Mar 20, 2025
5bba739
replae nonce in suffix with expected signer address
ItsNickBarry Mar 20, 2025
8db59a2
update comments
ItsNickBarry Mar 20, 2025
16328d2
Merge branch 'crypto-improvements' into ecdsa-context
ItsNickBarry Mar 20, 2025
3650961
use toEIP712RecoverableHash utiltity function in ECDSAMetaTransaction…
ItsNickBarry Mar 20, 2025
5511b36
fix comment
ItsNickBarry Mar 21, 2025
d440b5f
Merge branch 'storage-utils-improvements' into ecdsa-context
ItsNickBarry Mar 26, 2025
aa1e273
update pragma version statements
ItsNickBarry Mar 26, 2025
ef68de5
use Slot for ECDSAMetaTransactionContext
ItsNickBarry Mar 26, 2025
f83a461
Merge branch 'master' into ecdsa-context
ItsNickBarry Mar 27, 2025
89cce85
Merge branch 'msg-sender-trick' into ecdsa-context
ItsNickBarry Mar 27, 2025
7e3bad9
Merge branch 'bytes32-builder' into ecdsa-context
ItsNickBarry Mar 27, 2025
ede6b0a
Merge branch 'bytes32-builder' into ecdsa-context
ItsNickBarry Mar 27, 2025
7ea318e
use Bytes32Builder for ECDSAMetaTransactionContext storage
ItsNickBarry Mar 27, 2025
96aa9b7
integrate TransientReentrancyGuard into ECDSAMetaTransactionContext t…
ItsNickBarry Mar 28, 2025
54f2466
Merge branch 'slot-delete' into ecdsa-context
ItsNickBarry Mar 28, 2025
cdaed4b
use Slot clear function on context data, remove duplicate deletion
ItsNickBarry Mar 28, 2025
4d463e5
Merge branch 'master' into ecdsa-context
ItsNickBarry Mar 28, 2025
69ff4da
Merge branch 'bytes32-builder' into ecdsa-context
ItsNickBarry Mar 29, 2025
7e4d2ea
Merge branch 'master' into ecdsa-context
ItsNickBarry Mar 30, 2025
6ce5f66
Merge branch 'bytes32-builder' into ecdsa-context
ItsNickBarry Mar 30, 2025
c8c8cd2
use Bytes32Builder parse functions for context cache
ItsNickBarry Mar 30, 2025
f5ee530
Merge branch 'master' into ecdsa-context
ItsNickBarry Mar 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use Slot clear function on context data, remove duplicate deletion
ItsNickBarry committed Mar 28, 2025
commit cdaed4b459289f027cf3fcb396f8fe838f2d5d81
3 changes: 1 addition & 2 deletions contracts/meta/_ECDSAMetaTransactionContext.sol
Original file line number Diff line number Diff line change
@@ -201,8 +201,7 @@ abstract contract _ECDSAMetaTransactionContext is
* @dev clear the cached context to prevent replay attacks
*/
function _lockReentrancyGuard() internal virtual override {
TRANSIENT_SLOT.write(bytes32(0));
TRANSIENT_SLOT.next().write(bytes32(0));
TRANSIENT_SLOT.clear();
super._lockReentrancyGuard();
}
}