Fix Github actions test runs#42
Merged
adammathys merged 8 commits intoOct 27, 2025
Merged
Conversation
kjriga
force-pushed
the
fix-github-actions-workflow
branch
from
1afa9d6 to
b1bfa0b
Compare
Merged
kjriga
force-pushed
the
fix-github-actions-workflow
branch
3 times, most recently
from
acdd1e3 to
33058e9
Compare
Author
|
Just an update, my local spec suite passes. Figuring out github actions now. |
kjriga
force-pushed
the
fix-github-actions-workflow
branch
from
f2fca82 to
3f2332d
Compare
adammathys
reviewed
Oct 21, 2025
Comment on lines
+23
to
+28
| # Standard library gems that became separate in Ruby 3.4+ | ||
| gem 'bigdecimal' | ||
| gem 'mutex_m' | ||
| gem 'drb' | ||
| gem 'csv' | ||
| gem 'ostruct' |
Member
There was a problem hiding this comment.
I don't love this, particularly because I don't think this gem actually uses any of these itself. (Outside of ostruct in a couple of tests.)
We should probably look at making these gem dependencies of the appropriate Solidus gems that need them.
But since this is just the Gemfile, I'm okay with this for now.
kjriga
force-pushed
the
fix-github-actions-workflow
branch
2 times, most recently
from
f2faecd to
3120fbc
Compare
adammathys
reviewed
Oct 21, 2025
kjriga
force-pushed
the
fix-github-actions-workflow
branch
4 times, most recently
from
689365f to
6199e11
Compare
adammathys
approved these changes
Oct 21, 2025
jarednorman
reviewed
Oct 22, 2025
Member
jarednorman
left a comment
jarednorman
left a comment
There was a problem hiding this comment.
Looks all reasonable to me pending Adam's comments being addressed.
added 8 commits
October 27, 2025 10:16
Since this gem doesn't support Solidus 4+ yet.
To fix `uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)`
I got errors that these were not recognized.
To fix an error we got, ``` Error loading the 'sqlite3' Active Record adapter. Missing a gem it depends on? can't activate sqlite3 (~> 1.4), already activated sqlite3-2.7.4-arm64-darwin. Make sure all dependencies are added to Gemfile. ``` The error message shows the version it was erroring to activate. Locking it to that version and `bundle update sqlite3` fixed the issue.
Because we were build_stubbed'ing in these, the orders are missing some details that cause errors, such as 'no 'abbr' for nil'.
On the version we were using we got 'stack level too deep' spec failures. Locking it to 0.6.0 in the meantime solves this problem.
To fix
```
/home/runner/work/solidus_tracking/solidus_tracking/vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:12:in `<module:LoggerThreadSafeLevel>': uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)
Logger::Severity.constants.each do |severity|
^^^^^^
```
This could be removed once we're solely testing on Rails 7.1+, but
because this gem is a bit outdated (Solidus < 4) we need it for now.
The spec failures was showing extra callbacks being fired.
kjriga
force-pushed
the
fix-github-actions-workflow
branch
from
6199e11 to
afbfdf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After switching to Github actions, some things were broken. This covers fixing up various missing dependencies, failing specs, etc to get a green run.